Don't recreate desktop shortcut on update if it doesn't already exist

[khionu]

Each time Riot updates, it recreates the shortcut on my desktop. This is quite annoying, as I keep my desktop pretty clean.

[t3chguy]

electron-builder does not give us control over this: https://www.electron.build/configuration/squirrel-windows

[khionu]

Discord uses Squirrel as well, and does not have this issue.

[t3chguy]

Is there any certainty in them using electron-builder though or are they rocking some custom in-house thing?

[khionu]

I'll get back to you on that.

[aaronraimist]

@t3chguy the link you sent says

Squirrel.Windows target is maintained, but deprecated. Please use nsis instead.

and nsis does have an option you can set https://www.electron.build/configuration/nsis

createDesktopShortcut = true Boolean | “always” - Whether to create desktop shortcut. Set to always if to recreate also on reinstall (even if removed by user).

[t3chguy]

@aaronraimist this is known but Riot at least disliked nsis due to its update mechanism which was basically an uninstall followed by a new install which wasn't the most friendly flow.

[BloodyIron]

Surely there's some way to get this done, cmon this is really frustrating.

[ajayyy]

Yea, this is very frustrating

[ryanfleury]

Extremely frustrating that this has not been addressed in nearly 3 years. I mean, come on.

[aminomancer]

if we can't get low enough into Squirrel.Windows to prevent the shortcut from being created in the first place, can we at least script something to log whether the shortcut exists at the time the in-app update button is pressed, then remove the shortcut on app startup if the shortcut did not exist? it's not the most glamorous solution but it's better than making an unwanted file on every update (which is pretty frequent for me)

[elibroftw]

@t3chguy, what is used for the installer then? You can just check if the shortcut exists on desktop and if it does tell element to delete it after the new install.

[t3chguy]

@elibroftw #9210 (comment)

[elibroftw]

@t3chguy okay, then check if the shortcut exists before starting the auto install, and then delete the file afterwords. Use a settings key like "post-install" and then upon a launch, element should do the actions specified in the "post-install" key and then delete the post-install setting.

[elibroftw]

https://github.com/mongodb-js/electron-squirrel-startup
https://github.com/electron-archive/grunt-electron-installer#handling-squirrel-events

    case '--squirrel-updated':

      // Optionally do things such as:
      //
      // - Install desktop and start menu shortcuts
      // - Add your .exe to the PATH
      // - Write to the registry for things like file associations and
      //   explorer context menus

      // Always quit when done
      app.quit();

[elibroftw]

@t3chguy https://github.com/vector-im/element-desktop/blob/develop/src/squirrelhooks.ts#L41
What do you mean it's out of your hands, it's right here clearly in your hands.

[elibroftw]

Specifically, you can use --shortcut-locations=StartMenu https://stackoverflow.com/questions/30105150/handle-squirrels-event-on-an-electron-app or not call --createShortcuts at all.

[elibroftw]

Actually, I don't think you're actually supposed to call the Updater to do the work for you. The docs clearly say you only need to handle the argument, not that you need to call an Updater executable.

[elibroftw]

Manages Squirrel packages

Commands
      --install=VALUE        Install the app whose package is in the specified
                               directory
      --uninstall            Uninstall the app the same dir as Update.exe
      --download=VALUE       Download the releases specified by the URL and
                               write new results to stdout as JSON
      --checkForUpdate=VALUE Check for one available update and writes new
                               results to stdout as JSON
      --update=VALUE         Update the application to the latest remote
                               version specified by URL
      --releasify=VALUE      Update or generate a releases directory with a
                               given NuGet package
      --createMsi=VALUE      Update or generate a releases directory with a
                               given NuGet package
      --createShortcut=VALUE Create a shortcut for the given executable name
      --removeShortcut=VALUE Remove a shortcut for the given executable name
      --updateSelf=VALUE     Copy the currently executing Update.exe into the
                               default location

Options:
  -h, -?, --help             Display Help and exit
  -r, --releaseDir=VALUE     Path to a release directory to use with releasify
  -p, --packagesDir=VALUE    Path to the NuGet Packages directory for C# apps
      --bootstrapperExe=VALUE
                             Path to the Setup.exe to use as a template
  -g, --loadingGif=VALUE     Path to an animated GIF to be displayed during
                               installation
  -i, --icon=VALUE           Path to an ICO file that will be used for icon
                               shortcuts
      --setupIcon=VALUE      Path to an ICO file that will be used for the
                               Setup executable's icon
  -n, --signWithParams=VALUE Sign the installer via SignTool.exe with the
                               parameters given
  -s, --silent               Silent install
  -l, --shortcut-locations=VALUE
                             Comma-separated string of shortcut locations, e.g.
                               'Desktop,StartMenu'
      --no-msi               Don't generate an MSI package
      --no-delta             Don't generate delta packages to save time
      --framework-version=VALUE
                             Set the required .NET framework version, e.g.
                               net461

[elibroftw]

Yeah there's no reason to create shortcuts on an update like L41 does.

[t3chguy]

You're welcome to contribute it yourself, I don't use Windows anymore.

[joshsleeper]

@elibroftw while I agree with your sentiment and also want this feature, remember that github issues isn't a chat platform and people get emails for each new message.

instead of sending a bunch of messages in a row, consider either editing one comment to add more context or just not hitting send until you've fleshed it out more.

not trying to nag or shame, just trying to reduce everyone's email intake 😅