Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Don't linkify code blocks #7859

Merged
merged 9 commits into from
May 3, 2022
Merged

Don't linkify code blocks #7859

merged 9 commits into from
May 3, 2022

Conversation

robintown
Copy link
Member

@robintown robintown commented Feb 21, 2022 •
edited by github-actions bot
Loading

Type: defect

Closes element-hq/element-web#9613.

Here's what your changelog entry will look like:

🐛 Bug Fixes

Preview: https://pr7859--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@robintown
Don't linkify code blocks
3e08656 
Signed-off-by: Robin Townsend <robin@robin.town>
@robintown robintown requested a review from a team as a code owner February 21, 2022 16:33
@github-actions github-actions bot added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Feb 21, 2022
@robintown robintown marked this pull request as draft February 21, 2022 16:39
@t3chguy
Copy link
Member

t3chguy commented Feb 21, 2022

Hmm, it seems that github linkifies things in code blocks - so not sure whether this is the right path unfortunately

image

foo
https://github.com/matrix-org/matrix-react-sdk/pull/7859
https://github.com
github.com
bar

Maybe we should still linkify explicit URLs but skip implicit (github.com) ones. Github seems to never linkify implicit schema-less URLs.

@t3chguy t3chguy requested a review from a team February 21, 2022 16:41
@robintown
Copy link
Member Author

Good point, I'll see if there's an option for that…

@robintown
Put the linkify ignoreTags option in the right place
af25bb9 
Signed-off-by: Robin Townsend <robin@robin.town>
@robintown robintown marked this pull request as ready for review February 21, 2022 16:47
@robintown
Copy link
Member Author

robintown commented Feb 21, 2022 •
edited
Loading

Maybe we should still linkify explicit URLs but skip implicit (github.com) ones. Github seems to never linkify implicit schema-less URLs.

It looks like the only way to do this would be to set a class name on implicit URLs that causes them to be styled like normal text when inside code blocks (super hacky 😛)

edit: oh, but of course if we were to skip implicit URLs in general, that would be doable

@t3chguy
Copy link
Member

t3chguy commented Feb 21, 2022 •
edited
Loading

edit: oh, but of course if we were to skip implicit URLs in general, that would be doable

I doubt this would fly by product unfortunately.

I think the className based approach is not entirely insane, with CSS we could strip styling and pointer-actions, wonder if that'd prevent highlighting though (i'd expect that to be controlled via user-select instead)

@robintown
Copy link
Member Author

I spoke too soon, apparently the className option in linkifyjs only lets you decide what classes to add based on the href and not the text itself, so you can't tell whether the text contains a scheme or not :( I think I'll just leave this as-is, then.

@robintown
Add code to list of ignored linkification tags as well
a293d19 
Signed-off-by: Robin Townsend <robin@robin.town>
@robintown
Test that code blocks skip linkification
05270f3 
Signed-off-by: Robin Townsend <robin@robin.town>
@robintown
Move test to the right spot
52a8a5c 
Signed-off-by: Robin Townsend <robin@robin.town>
t3chguy
t3chguy approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise

@daniellekirkwood daniellekirkwood self-assigned this Feb 28, 2022
@daniellekirkwood
Copy link

Screenshot 2022-05-02 at 10 15 50

this is what i see - is this the expected behaviour as discussed above?

@robintown
Copy link
Member Author

@daniellekirkwood Yes, that's expected

@daniellekirkwood
Copy link

GReat, then product approves 👍

@robintown robintown enabled auto-merge (squash) May 2, 2022 23:56
@github-actions github-actions bot temporarily deployed to Netlify May 3, 2022 00:24 Destroyed
@robintown robintown merged commit 1c70696 into matrix-org:develop May 3, 2022
su-ex added a commit to SchildiChat/element-desktop that referenced this pull request May 10, 2022
@su-ex
Merge tag 'v1.10.12' into sc
78fcd71 
* Made the location map change the cursor to a pointer so it looks like it's clickable (https ([\#8451](matrix-org/matrix-react-sdk#8451)). Fixes element-hq/element-web#21991. Contributed by @Odyssey346.
* Implement improved spacing for the thread list and timeline ([\#8337](matrix-org/matrix-react-sdk#8337)). Fixes element-hq/element-web#21759. Contributed by @luixxiul.
* LLS: expose way to enable live sharing labs flag from location dialog ([\#8416](matrix-org/matrix-react-sdk#8416)).
* Fix source text boxes in View Source modal should have full width ([\#8425](matrix-org/matrix-react-sdk#8425)). Fixes element-hq/element-web#21938. Contributed by @EECvision.
* Read Receipts: never show +1, if it’s just 4, show all of them ([\#8428](matrix-org/matrix-react-sdk#8428)). Fixes element-hq/element-web#21935.
* Add opt-in analytics to onboarding tasks ([\#8409](matrix-org/matrix-react-sdk#8409)). Fixes element-hq/element-web#21705.
* Allow user to control if they are signed out of all devices when changing password ([\#8259](matrix-org/matrix-react-sdk#8259)). Fixes element-hq/element-web#2671.
* Implement new Read Receipt design ([\#8389](matrix-org/matrix-react-sdk#8389)). Fixes element-hq/element-web#20574.
* Stick connected video rooms to the top of the room list ([\#8353](matrix-org/matrix-react-sdk#8353)).
* LLS: fix jumpy maximised map ([\#8387](matrix-org/matrix-react-sdk#8387)).
* Persist audio and video mute state in video rooms ([\#8376](matrix-org/matrix-react-sdk#8376)).
* Forcefully disconnect from video rooms on logout and tab close ([\#8375](matrix-org/matrix-react-sdk#8375)).
* Add local echo of connected devices in video rooms ([\#8368](matrix-org/matrix-react-sdk#8368)).
* Improve text of account deactivation dialog ([\#8371](matrix-org/matrix-react-sdk#8371)). Fixes element-hq/element-web#17421.
* Live location sharing: own live beacon status on maximised view ([\#8374](matrix-org/matrix-react-sdk#8374)).
* Show a lobby screen in video rooms ([\#8287](matrix-org/matrix-react-sdk#8287)).
* Settings toggle to disable Composer Markdown ([\#8358](matrix-org/matrix-react-sdk#8358)). Fixes element-hq/element-web#20321.
* Cache localStorage objects for SettingsStore ([\#8366](matrix-org/matrix-react-sdk#8366)).
* Bring `View Source` back from behind developer mode ([\#8369](matrix-org/matrix-react-sdk#8369)). Fixes element-hq/element-web#21771.
* Fix update from creating desktop shortcut ([\element-hq#333](element-hq#333)). Fixes element-hq/element-web#9210. Contributed by @elibroftw.
* Fix macOS and Linux build regressions ([\element-hq#345](element-hq#345)).
* Allow loading language files with two part language code ([\element-hq#339](element-hq#339)). Contributed by @TPiUnikie.
* Fix Jitsi Meet getting wedged at startup in some cases ([\#21995](element-hq/element-web#21995)).
* Fix camera getting muted when disconnecting from a video room ([\#21958](element-hq/element-web#21958)).
* Fix race conditions around threads ([\#8448](matrix-org/matrix-react-sdk#8448)). Fixes element-hq/element-web#21627.
* Fix reading of cached room device setting values ([\#8495](matrix-org/matrix-react-sdk#8495)).
* Fix issue with dispatch happening mid-dispatch due to js-sdk emit ([\#8473](matrix-org/matrix-react-sdk#8473)). Fixes element-hq/element-web#22019.
* Match MSC behaviour for threads when disabled (thread-aware mode) ([\#8476](matrix-org/matrix-react-sdk#8476)). Fixes element-hq/element-web#22033.
* Specify position of DisambiguatedProfile inside a thread on bubble message layout ([\#8452](matrix-org/matrix-react-sdk#8452)). Fixes element-hq/element-web#21998. Contributed by @luixxiul.
* Location sharing: do not trackuserlocation in location picker ([\#8466](matrix-org/matrix-react-sdk#8466)). Fixes element-hq/element-web#22013.
* fix text and map indent in thread view ([\#8462](matrix-org/matrix-react-sdk#8462)). Fixes element-hq/element-web#21997.
* Live location sharing: don't group beacon info with room creation summary ([\#8468](matrix-org/matrix-react-sdk#8468)).
* Don't linkify code blocks ([\#7859](matrix-org/matrix-react-sdk#7859)). Fixes element-hq/element-web#9613.
* read receipts: improve tooltips to show names of users ([\#8438](matrix-org/matrix-react-sdk#8438)). Fixes element-hq/element-web#21940.
* Fix poll overflowing a reply tile on bubble message layout ([\#8459](matrix-org/matrix-react-sdk#8459)). Fixes element-hq/element-web#22005. Contributed by @luixxiul.
* Fix text link buttons on UserInfo panel ([\#8247](matrix-org/matrix-react-sdk#8247)). Fixes element-hq/element-web#21702. Contributed by @luixxiul.
* Clear local storage settings handler cache on logout ([\#8454](matrix-org/matrix-react-sdk#8454)). Fixes element-hq/element-web#21994.
* Fix jump to bottom button being always displayed in non-overflowing timelines ([\#8460](matrix-org/matrix-react-sdk#8460)). Fixes element-hq/element-web#22003.
* fix timeline search with empty text box should do nothing ([\#8262](matrix-org/matrix-react-sdk#8262)). Fixes element-hq/element-web#21714. Contributed by @EECvision.
* Fixes "space panel kebab menu is rendered out of view on sub spaces"  ([\#8350](matrix-org/matrix-react-sdk#8350)). Contributed by @yaya-usman.
* Add margin to the location map inside ThreadView ([\#8442](matrix-org/matrix-react-sdk#8442)). Fixes element-hq/element-web#21982. Contributed by @luixxiul.
* Patch: "Reloading the registration page should warn about data loss" ([\#8377](matrix-org/matrix-react-sdk#8377)). Contributed by @yaya-usman.
* Live location sharing: fix safari timestamps pt 2 ([\#8443](matrix-org/matrix-react-sdk#8443)).
* Fix issue with thread notification state ignoring initial events ([\#8417](matrix-org/matrix-react-sdk#8417)). Fixes element-hq/element-web#21927.
* Fix event text overflow on bubble message layout ([\#8391](matrix-org/matrix-react-sdk#8391)). Fixes element-hq/element-web#21882. Contributed by @luixxiul.
* Disable the message action bar when hovering over the 1px border between threads on the list ([\#8429](matrix-org/matrix-react-sdk#8429)). Fixes element-hq/element-web#21955. Contributed by @luixxiul.
* correctly align read receipts to state events in bubble layout ([\#8419](matrix-org/matrix-react-sdk#8419)). Fixes element-hq/element-web#21899.
* Fix issue with underfilled timelines when barren of content ([\#8432](matrix-org/matrix-react-sdk#8432)). Fixes element-hq/element-web#21930.
* Fix baseline misalignment of thread panel summary by deduplication ([\#8413](matrix-org/matrix-react-sdk#8413)).
* Fix editing of non-html replies ([\#8418](matrix-org/matrix-react-sdk#8418)). Fixes element-hq/element-web#21928.
* Read Receipts "Fall from the Sky" ([\#8414](matrix-org/matrix-react-sdk#8414)). Fixes element-hq/element-web#21888.
* Make read receipts handle nullable roomMembers correctly ([\#8410](matrix-org/matrix-react-sdk#8410)). Fixes element-hq/element-web#21896.
* Don't form continuations on either side of a thread root ([\#8408](matrix-org/matrix-react-sdk#8408)). Fixes element-hq/element-web#20908.
* Fix centering issue with sticker placeholder ([\#8404](matrix-org/matrix-react-sdk#8404)). Fixes element-hq/element-web#18014 and element-hq/element-web#6449.
* Disable download option on <video/> , preferring dedicated download button ([\#8403](matrix-org/matrix-react-sdk#8403)). Fixes element-hq/element-web#21902.
* Fix infinite loop when pinning/unpinning persistent widgets ([\#8396](matrix-org/matrix-react-sdk#8396)). Fixes element-hq/element-web#21864.
* Tweak ReadReceiptGroup to better handle disambiguation ([\#8402](matrix-org/matrix-react-sdk#8402)). Fixes element-hq/element-web#21897.
* stop the bottom edge of buttons getting clipped in devtools ([\#8400](matrix-org/matrix-react-sdk#8400)).
* Fix issue with threads timelines with few events cropping events ([\#8392](matrix-org/matrix-react-sdk#8392)). Fixes element-hq/element-web#20594.
* Changed font-weight to 400 to support light weight font ([\#8345](matrix-org/matrix-react-sdk#8345)). Fixes element-hq/element-web#21171. Contributed by @goelesha.
* Fix issue with thread panel not updating when it loads on first render ([\#8382](matrix-org/matrix-react-sdk#8382)). Fixes element-hq/element-web#21737.
* fix: "Mention highlight and cursor hover highlight has different corner radius" ([\#8384](matrix-org/matrix-react-sdk#8384)). Contributed by @yaya-usman.
* Fix regression around haveRendererForEvent for hidden events ([\#8379](matrix-org/matrix-react-sdk#8379)). Fixes element-hq/element-web#21862 and element-hq/element-web#21725.
* Fix regression around the room list treeview keyboard a11y ([\#8385](matrix-org/matrix-react-sdk#8385)). Fixes element-hq/element-web#21436.
* Remove float property to let the margin between events appear on bubble message layout ([\#8373](matrix-org/matrix-react-sdk#8373)). Fixes element-hq/element-web#21861. Contributed by @luixxiul.
* Fix race in Registration between server change and flows fetch ([\#8359](matrix-org/matrix-react-sdk#8359)). Fixes element-hq/element-web#21800.
* fix rainbow breaks compound emojis ([\#8245](matrix-org/matrix-react-sdk#8245)). Fixes element-hq/element-web#21371. Contributed by @EECvision.
* Fix RightPanelStore handling first room on app launch wrong ([\#8370](matrix-org/matrix-react-sdk#8370)). Fixes element-hq/element-web#21741.
* Fix UnknownBody error message unalignment ([\#8346](matrix-org/matrix-react-sdk#8346)). Fixes element-hq/element-web#21828. Contributed by @luixxiul.
* Use -webkit-line-clamp for the room header topic overflow ([\#8367](matrix-org/matrix-react-sdk#8367)). Fixes element-hq/element-web#21852. Contributed by @luixxiul.
* Fix issue with ServerInfo crashing the modal ([\#8364](matrix-org/matrix-react-sdk#8364)).
* Fixes around threads beta in degraded mode ([\#8319](matrix-org/matrix-react-sdk#8319)). Fixes element-hq/element-web#21762.
su-ex added a commit to SchildiChat/element-web that referenced this pull request May 10, 2022
@su-ex
Merge tag 'v1.10.12' into sc
815e736 
* Made the location map change the cursor to a pointer so it looks like it's clickable (https ([\element-hq#8451](matrix-org/matrix-react-sdk#8451)). Fixes element-hq#21991. Contributed by @Odyssey346.
* Implement improved spacing for the thread list and timeline ([\element-hq#8337](matrix-org/matrix-react-sdk#8337)). Fixes element-hq#21759. Contributed by @luixxiul.
* LLS: expose way to enable live sharing labs flag from location dialog ([\element-hq#8416](matrix-org/matrix-react-sdk#8416)).
* Fix source text boxes in View Source modal should have full width ([\element-hq#8425](matrix-org/matrix-react-sdk#8425)). Fixes element-hq#21938. Contributed by @EECvision.
* Read Receipts: never show +1, if it’s just 4, show all of them ([\element-hq#8428](matrix-org/matrix-react-sdk#8428)). Fixes element-hq#21935.
* Add opt-in analytics to onboarding tasks ([\element-hq#8409](matrix-org/matrix-react-sdk#8409)). Fixes element-hq#21705.
* Allow user to control if they are signed out of all devices when changing password ([\element-hq#8259](matrix-org/matrix-react-sdk#8259)). Fixes element-hq#2671.
* Implement new Read Receipt design ([\element-hq#8389](matrix-org/matrix-react-sdk#8389)). Fixes element-hq#20574.
* Stick connected video rooms to the top of the room list ([\element-hq#8353](matrix-org/matrix-react-sdk#8353)).
* LLS: fix jumpy maximised map ([\element-hq#8387](matrix-org/matrix-react-sdk#8387)).
* Persist audio and video mute state in video rooms ([\element-hq#8376](matrix-org/matrix-react-sdk#8376)).
* Forcefully disconnect from video rooms on logout and tab close ([\element-hq#8375](matrix-org/matrix-react-sdk#8375)).
* Add local echo of connected devices in video rooms ([\element-hq#8368](matrix-org/matrix-react-sdk#8368)).
* Improve text of account deactivation dialog ([\element-hq#8371](matrix-org/matrix-react-sdk#8371)). Fixes element-hq#17421.
* Live location sharing: own live beacon status on maximised view ([\element-hq#8374](matrix-org/matrix-react-sdk#8374)).
* Show a lobby screen in video rooms ([\element-hq#8287](matrix-org/matrix-react-sdk#8287)).
* Settings toggle to disable Composer Markdown ([\element-hq#8358](matrix-org/matrix-react-sdk#8358)). Fixes element-hq#20321.
* Cache localStorage objects for SettingsStore ([\element-hq#8366](matrix-org/matrix-react-sdk#8366)).
* Bring `View Source` back from behind developer mode ([\element-hq#8369](matrix-org/matrix-react-sdk#8369)). Fixes element-hq#21771.
* Fix Jitsi Meet getting wedged at startup in some cases ([\element-hq#21995](element-hq#21995)).
* Fix camera getting muted when disconnecting from a video room ([\element-hq#21958](element-hq#21958)).
* Fix race conditions around threads ([\element-hq#8448](matrix-org/matrix-react-sdk#8448)). Fixes element-hq#21627.
* Fix reading of cached room device setting values ([\element-hq#8495](matrix-org/matrix-react-sdk#8495)).
* Fix issue with dispatch happening mid-dispatch due to js-sdk emit ([\element-hq#8473](matrix-org/matrix-react-sdk#8473)). Fixes element-hq#22019.
* Match MSC behaviour for threads when disabled (thread-aware mode) ([\element-hq#8476](matrix-org/matrix-react-sdk#8476)). Fixes element-hq#22033.
* Specify position of DisambiguatedProfile inside a thread on bubble message layout ([\element-hq#8452](matrix-org/matrix-react-sdk#8452)). Fixes element-hq#21998. Contributed by @luixxiul.
* Location sharing: do not trackuserlocation in location picker ([\element-hq#8466](matrix-org/matrix-react-sdk#8466)). Fixes element-hq#22013.
* fix text and map indent in thread view ([\element-hq#8462](matrix-org/matrix-react-sdk#8462)). Fixes element-hq#21997.
* Live location sharing: don't group beacon info with room creation summary ([\element-hq#8468](matrix-org/matrix-react-sdk#8468)).
* Don't linkify code blocks ([\element-hq#7859](matrix-org/matrix-react-sdk#7859)). Fixes element-hq#9613.
* read receipts: improve tooltips to show names of users ([\element-hq#8438](matrix-org/matrix-react-sdk#8438)). Fixes element-hq#21940.
* Fix poll overflowing a reply tile on bubble message layout ([\element-hq#8459](matrix-org/matrix-react-sdk#8459)). Fixes element-hq#22005. Contributed by @luixxiul.
* Fix text link buttons on UserInfo panel ([\element-hq#8247](matrix-org/matrix-react-sdk#8247)). Fixes element-hq#21702. Contributed by @luixxiul.
* Clear local storage settings handler cache on logout ([\element-hq#8454](matrix-org/matrix-react-sdk#8454)). Fixes element-hq#21994.
* Fix jump to bottom button being always displayed in non-overflowing timelines ([\element-hq#8460](matrix-org/matrix-react-sdk#8460)). Fixes element-hq#22003.
* fix timeline search with empty text box should do nothing ([\element-hq#8262](matrix-org/matrix-react-sdk#8262)). Fixes element-hq#21714. Contributed by @EECvision.
* Fixes "space panel kebab menu is rendered out of view on sub spaces"  ([\element-hq#8350](matrix-org/matrix-react-sdk#8350)). Contributed by @yaya-usman.
* Add margin to the location map inside ThreadView ([\element-hq#8442](matrix-org/matrix-react-sdk#8442)). Fixes element-hq#21982. Contributed by @luixxiul.
* Patch: "Reloading the registration page should warn about data loss" ([\element-hq#8377](matrix-org/matrix-react-sdk#8377)). Contributed by @yaya-usman.
* Live location sharing: fix safari timestamps pt 2 ([\element-hq#8443](matrix-org/matrix-react-sdk#8443)).
* Fix issue with thread notification state ignoring initial events ([\element-hq#8417](matrix-org/matrix-react-sdk#8417)). Fixes element-hq#21927.
* Fix event text overflow on bubble message layout ([\element-hq#8391](matrix-org/matrix-react-sdk#8391)). Fixes element-hq#21882. Contributed by @luixxiul.
* Disable the message action bar when hovering over the 1px border between threads on the list ([\element-hq#8429](matrix-org/matrix-react-sdk#8429)). Fixes element-hq#21955. Contributed by @luixxiul.
* correctly align read receipts to state events in bubble layout ([\element-hq#8419](matrix-org/matrix-react-sdk#8419)). Fixes element-hq#21899.
* Fix issue with underfilled timelines when barren of content ([\element-hq#8432](matrix-org/matrix-react-sdk#8432)). Fixes element-hq#21930.
* Fix baseline misalignment of thread panel summary by deduplication ([\element-hq#8413](matrix-org/matrix-react-sdk#8413)).
* Fix editing of non-html replies ([\element-hq#8418](matrix-org/matrix-react-sdk#8418)). Fixes element-hq#21928.
* Read Receipts "Fall from the Sky" ([\element-hq#8414](matrix-org/matrix-react-sdk#8414)). Fixes element-hq#21888.
* Make read receipts handle nullable roomMembers correctly ([\element-hq#8410](matrix-org/matrix-react-sdk#8410)). Fixes element-hq#21896.
* Don't form continuations on either side of a thread root ([\element-hq#8408](matrix-org/matrix-react-sdk#8408)). Fixes element-hq#20908.
* Fix centering issue with sticker placeholder ([\element-hq#8404](matrix-org/matrix-react-sdk#8404)). Fixes element-hq#18014 and element-hq#6449.
* Disable download option on <video/> , preferring dedicated download button ([\element-hq#8403](matrix-org/matrix-react-sdk#8403)). Fixes element-hq#21902.
* Fix infinite loop when pinning/unpinning persistent widgets ([\element-hq#8396](matrix-org/matrix-react-sdk#8396)). Fixes element-hq#21864.
* Tweak ReadReceiptGroup to better handle disambiguation ([\element-hq#8402](matrix-org/matrix-react-sdk#8402)). Fixes element-hq#21897.
* stop the bottom edge of buttons getting clipped in devtools ([\element-hq#8400](matrix-org/matrix-react-sdk#8400)).
* Fix issue with threads timelines with few events cropping events ([\element-hq#8392](matrix-org/matrix-react-sdk#8392)). Fixes element-hq#20594.
* Changed font-weight to 400 to support light weight font ([\element-hq#8345](matrix-org/matrix-react-sdk#8345)). Fixes element-hq#21171. Contributed by @goelesha.
* Fix issue with thread panel not updating when it loads on first render ([\element-hq#8382](matrix-org/matrix-react-sdk#8382)). Fixes element-hq#21737.
* fix: "Mention highlight and cursor hover highlight has different corner radius" ([\element-hq#8384](matrix-org/matrix-react-sdk#8384)). Contributed by @yaya-usman.
* Fix regression around haveRendererForEvent for hidden events ([\element-hq#8379](matrix-org/matrix-react-sdk#8379)). Fixes element-hq#21862 and element-hq#21725.
* Fix regression around the room list treeview keyboard a11y ([\element-hq#8385](matrix-org/matrix-react-sdk#8385)). Fixes element-hq#21436.
* Remove float property to let the margin between events appear on bubble message layout ([\element-hq#8373](matrix-org/matrix-react-sdk#8373)). Fixes element-hq#21861. Contributed by @luixxiul.
* Fix race in Registration between server change and flows fetch ([\element-hq#8359](matrix-org/matrix-react-sdk#8359)). Fixes element-hq#21800.
* fix rainbow breaks compound emojis ([\element-hq#8245](matrix-org/matrix-react-sdk#8245)). Fixes element-hq#21371. Contributed by @EECvision.
* Fix RightPanelStore handling first room on app launch wrong ([\element-hq#8370](matrix-org/matrix-react-sdk#8370)). Fixes element-hq#21741.
* Fix UnknownBody error message unalignment ([\element-hq#8346](matrix-org/matrix-react-sdk#8346)). Fixes element-hq#21828. Contributed by @luixxiul.
* Use -webkit-line-clamp for the room header topic overflow ([\element-hq#8367](matrix-org/matrix-react-sdk#8367)). Fixes element-hq#21852. Contributed by @luixxiul.
* Fix issue with ServerInfo crashing the modal ([\element-hq#8364](matrix-org/matrix-react-sdk#8364)).
* Fixes around threads beta in degraded mode ([\element-hq#8319](matrix-org/matrix-react-sdk#8319)). Fixes element-hq#21762.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this pull request May 10, 2022
@su-ex
Merge tag 'v3.44.0' into sc
4a0d9fe 
* Made the location map change the cursor to a pointer so it looks like it's clickable (https ([\matrix-org#8451](matrix-org#8451)). Fixes element-hq/element-web#21991. Contributed by @Odyssey346.
* Implement improved spacing for the thread list and timeline ([\matrix-org#8337](matrix-org#8337)). Fixes element-hq/element-web#21759. Contributed by @luixxiul.
* LLS: expose way to enable live sharing labs flag from location dialog ([\matrix-org#8416](matrix-org#8416)).
* Fix source text boxes in View Source modal should have full width ([\matrix-org#8425](matrix-org#8425)). Fixes element-hq/element-web#21938. Contributed by @EECvision.
* Read Receipts: never show +1, if it’s just 4, show all of them ([\matrix-org#8428](matrix-org#8428)). Fixes element-hq/element-web#21935.
* Add opt-in analytics to onboarding tasks ([\matrix-org#8409](matrix-org#8409)). Fixes element-hq/element-web#21705.
* Allow user to control if they are signed out of all devices when changing password ([\matrix-org#8259](matrix-org#8259)). Fixes element-hq/element-web#2671.
* Implement new Read Receipt design ([\matrix-org#8389](matrix-org#8389)). Fixes element-hq/element-web#20574.
* Stick connected video rooms to the top of the room list ([\matrix-org#8353](matrix-org#8353)).
* LLS: fix jumpy maximised map ([\matrix-org#8387](matrix-org#8387)).
* Persist audio and video mute state in video rooms ([\matrix-org#8376](matrix-org#8376)).
* Forcefully disconnect from video rooms on logout and tab close ([\matrix-org#8375](matrix-org#8375)).
* Add local echo of connected devices in video rooms ([\matrix-org#8368](matrix-org#8368)).
* Improve text of account deactivation dialog ([\matrix-org#8371](matrix-org#8371)). Fixes element-hq/element-web#17421.
* Live location sharing: own live beacon status on maximised view ([\matrix-org#8374](matrix-org#8374)).
* Show a lobby screen in video rooms ([\matrix-org#8287](matrix-org#8287)).
* Settings toggle to disable Composer Markdown ([\matrix-org#8358](matrix-org#8358)). Fixes element-hq/element-web#20321.
* Cache localStorage objects for SettingsStore ([\matrix-org#8366](matrix-org#8366)).
* Bring `View Source` back from behind developer mode ([\matrix-org#8369](matrix-org#8369)). Fixes element-hq/element-web#21771.
* Fix race conditions around threads ([\matrix-org#8448](matrix-org#8448)). Fixes element-hq/element-web#21627.
* Fix reading of cached room device setting values ([\matrix-org#8495](matrix-org#8495)).
* Fix issue with dispatch happening mid-dispatch due to js-sdk emit ([\matrix-org#8473](matrix-org#8473)). Fixes element-hq/element-web#22019.
* Match MSC behaviour for threads when disabled (thread-aware mode) ([\matrix-org#8476](matrix-org#8476)). Fixes element-hq/element-web#22033.
* Specify position of DisambiguatedProfile inside a thread on bubble message layout ([\matrix-org#8452](matrix-org#8452)). Fixes element-hq/element-web#21998. Contributed by @luixxiul.
* Location sharing: do not trackuserlocation in location picker ([\matrix-org#8466](matrix-org#8466)). Fixes element-hq/element-web#22013.
* fix text and map indent in thread view ([\matrix-org#8462](matrix-org#8462)). Fixes element-hq/element-web#21997.
* Live location sharing: don't group beacon info with room creation summary ([\matrix-org#8468](matrix-org#8468)).
* Don't linkify code blocks ([\matrix-org#7859](matrix-org#7859)). Fixes element-hq/element-web#9613.
* read receipts: improve tooltips to show names of users ([\matrix-org#8438](matrix-org#8438)). Fixes element-hq/element-web#21940.
* Fix poll overflowing a reply tile on bubble message layout ([\matrix-org#8459](matrix-org#8459)). Fixes element-hq/element-web#22005. Contributed by @luixxiul.
* Fix text link buttons on UserInfo panel ([\matrix-org#8247](matrix-org#8247)). Fixes element-hq/element-web#21702. Contributed by @luixxiul.
* Clear local storage settings handler cache on logout ([\matrix-org#8454](matrix-org#8454)). Fixes element-hq/element-web#21994.
* Fix jump to bottom button being always displayed in non-overflowing timelines ([\matrix-org#8460](matrix-org#8460)). Fixes element-hq/element-web#22003.
* fix timeline search with empty text box should do nothing ([\matrix-org#8262](matrix-org#8262)). Fixes element-hq/element-web#21714. Contributed by @EECvision.
* Fixes "space panel kebab menu is rendered out of view on sub spaces"  ([\matrix-org#8350](matrix-org#8350)). Contributed by @yaya-usman.
* Add margin to the location map inside ThreadView ([\matrix-org#8442](matrix-org#8442)). Fixes element-hq/element-web#21982. Contributed by @luixxiul.
* Patch: "Reloading the registration page should warn about data loss" ([\matrix-org#8377](matrix-org#8377)). Contributed by @yaya-usman.
* Live location sharing: fix safari timestamps pt 2 ([\matrix-org#8443](matrix-org#8443)).
* Fix issue with thread notification state ignoring initial events ([\matrix-org#8417](matrix-org#8417)). Fixes element-hq/element-web#21927.
* Fix event text overflow on bubble message layout ([\matrix-org#8391](matrix-org#8391)). Fixes element-hq/element-web#21882. Contributed by @luixxiul.
* Disable the message action bar when hovering over the 1px border between threads on the list ([\matrix-org#8429](matrix-org#8429)). Fixes element-hq/element-web#21955. Contributed by @luixxiul.
* correctly align read receipts to state events in bubble layout ([\matrix-org#8419](matrix-org#8419)). Fixes element-hq/element-web#21899.
* Fix issue with underfilled timelines when barren of content ([\matrix-org#8432](matrix-org#8432)). Fixes element-hq/element-web#21930.
* Fix baseline misalignment of thread panel summary by deduplication ([\matrix-org#8413](matrix-org#8413)).
* Fix editing of non-html replies ([\matrix-org#8418](matrix-org#8418)). Fixes element-hq/element-web#21928.
* Read Receipts "Fall from the Sky" ([\matrix-org#8414](matrix-org#8414)). Fixes element-hq/element-web#21888.
* Make read receipts handle nullable roomMembers correctly ([\matrix-org#8410](matrix-org#8410)). Fixes element-hq/element-web#21896.
* Don't form continuations on either side of a thread root ([\matrix-org#8408](matrix-org#8408)). Fixes element-hq/element-web#20908.
* Fix centering issue with sticker placeholder ([\matrix-org#8404](matrix-org#8404)). Fixes element-hq/element-web#18014 and element-hq/element-web#6449.
* Disable download option on <video/> , preferring dedicated download button ([\matrix-org#8403](matrix-org#8403)). Fixes element-hq/element-web#21902.
* Fix infinite loop when pinning/unpinning persistent widgets ([\matrix-org#8396](matrix-org#8396)). Fixes element-hq/element-web#21864.
* Tweak ReadReceiptGroup to better handle disambiguation ([\matrix-org#8402](matrix-org#8402)). Fixes element-hq/element-web#21897.
* stop the bottom edge of buttons getting clipped in devtools ([\matrix-org#8400](matrix-org#8400)).
* Fix issue with threads timelines with few events cropping events ([\matrix-org#8392](matrix-org#8392)). Fixes element-hq/element-web#20594.
* Changed font-weight to 400 to support light weight font ([\matrix-org#8345](matrix-org#8345)). Fixes element-hq/element-web#21171. Contributed by @goelesha.
* Fix issue with thread panel not updating when it loads on first render ([\matrix-org#8382](matrix-org#8382)). Fixes element-hq/element-web#21737.
* fix: "Mention highlight and cursor hover highlight has different corner radius" ([\matrix-org#8384](matrix-org#8384)). Contributed by @yaya-usman.
* Fix regression around haveRendererForEvent for hidden events ([\matrix-org#8379](matrix-org#8379)). Fixes element-hq/element-web#21862 and element-hq/element-web#21725.
* Fix regression around the room list treeview keyboard a11y ([\matrix-org#8385](matrix-org#8385)). Fixes element-hq/element-web#21436.
* Remove float property to let the margin between events appear on bubble message layout ([\matrix-org#8373](matrix-org#8373)). Fixes element-hq/element-web#21861. Contributed by @luixxiul.
* Fix race in Registration between server change and flows fetch ([\matrix-org#8359](matrix-org#8359)). Fixes element-hq/element-web#21800.
* fix rainbow breaks compound emojis ([\matrix-org#8245](matrix-org#8245)). Fixes element-hq/element-web#21371. Contributed by @EECvision.
* Fix RightPanelStore handling first room on app launch wrong ([\matrix-org#8370](matrix-org#8370)). Fixes element-hq/element-web#21741.
* Fix UnknownBody error message unalignment ([\matrix-org#8346](matrix-org#8346)). Fixes element-hq/element-web#21828. Contributed by @luixxiul.
* Use -webkit-line-clamp for the room header topic overflow ([\matrix-org#8367](matrix-org#8367)). Fixes element-hq/element-web#21852. Contributed by @luixxiul.
* Fix issue with ServerInfo crashing the modal ([\matrix-org#8364](matrix-org#8364)).
* Fixes around threads beta in degraded mode ([\matrix-org#8319](matrix-org#8319)). Fixes element-hq/element-web#21762.
@dzlandis dzlandis mentioned this pull request Feb 25, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daniellekirkwood daniellekirkwood daniellekirkwood approved these changes

@t3chguy t3chguy t3chguy approved these changes

@marcusmueller marcusmueller marcusmueller approved these changes

Assignees

@daniellekirkwood daniellekirkwood

Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text in code blocks is linkified
4 participants
@robintown @t3chguy @daniellekirkwood @marcusmueller