Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Disable url tooltips whilst they are very broken" #23030

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Revert "Disable url tooltips whilst they are very broken" #23030

merged 1 commit into from
Aug 9, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 8, 2022 •
edited by github-actions bot
Loading

Reverts #22976

Requires matrix-org/matrix-react-sdk#9139

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Aug 8, 2022
@t3chguy t3chguy requested a review from a team as a code owner August 8, 2022 14:53
turt2live
turt2live reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to consider #22953 still?

@t3chguy
Copy link
Member Author

t3chguy commented Aug 8, 2022

Don't we need to consider #22953 still?

That's fixed by the required react SDK pr, including tests

turt2live
turt2live approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this side lgtm

@t3chguy t3chguy merged commit 822e262 into develop Aug 9, 2022
@t3chguy t3chguy deleted the revert-22976-t3chguy-patch-1 branch August 9, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from element-hq/element-web-reviewers

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from element-hq/element-web-reviewers

@SimonBrandner SimonBrandner Awaiting requested review from SimonBrandner SimonBrandner is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @turt2live