Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fixes around URL tooltips and in-app matrix.to link handling #9139

Merged
merged 7 commits into from
Aug 9, 2022
Merged

Fixes around URL tooltips and in-app matrix.to link handling #9139

merged 7 commits into from
Aug 9, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 5, 2022 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#22953
Fixes element-hq/element-web#22970

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 5, 2022
@t3chguy t3chguy changed the title Fixes for url tooltips Fixes around URL tooltips and in-app matrix.to link handling Aug 8, 2022
@t3chguy t3chguy marked this pull request as ready for review August 8, 2022 14:51
@t3chguy t3chguy requested a review from a team as a code owner August 8, 2022 14:51
@t3chguy t3chguy added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Aug 8, 2022
@t3chguy t3chguy mentioned this pull request Aug 8, 2022
Merged
turt2live
turt2live reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm - I think the code does the correct thing, but have not manually tested

src/components/views/messages/TextualBody.tsx Outdated Show resolved Hide resolved
src/utils/tooltipify.tsx Show resolved Hide resolved
@t3chguy t3chguy requested a review from turt2live August 9, 2022 11:49
@t3chguy t3chguy merged commit e63072e into develop Aug 9, 2022
@t3chguy t3chguy deleted the t3chguy/url-tooltip-fixes branch August 9, 2022 14:37
kerryarchibald pushed a commit that referenced this pull request Aug 10, 2022
@t3chguy
Fixes around URL tooltips and in-app matrix.to link handling (#9139)
c7430c9 
* Add regression test for tooltipify exposing raw HTML

* Handle m.to links involving children better

* Comments

* Fix mistaken assertion
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

@turt2live turt2live Awaiting requested review from turt2live

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Milestone
No milestone
3 participants
@t3chguy @dbkr @turt2live