Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated screen to show open source licenses in Gplay variant #3207

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 17, 2024

Content

Add a entry point in the About screen to the Activity generated by com.google.android.gms.oss-licenses-plugin to render open source licenses. It was already done the same way on Element Android.

Motivation and context

Be compliant with open source licenses requirements.

Screenshots / GIFs

OpenSourceLicenses

Tests

  • Install the app and navigate to Settings / About / Open source licenses

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Misc For other changes labels Jul 17, 2024
@bmarty bmarty requested a review from a team as a code owner July 17, 2024 14:02
@bmarty bmarty requested review from jmartinesp and removed request for a team July 17, 2024 14:02
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 17, 2024
Copy link
Contributor

github-actions bot commented Jul 17, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/TxPEPq

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm building a release version locally to check how it looks like!

@jmartinesp
Copy link
Member

Quality Gate Failed Quality Gate failed

Failed conditions 2 Security Hotspots

See analysis details on SonarCloud

Same false positives in every single PR that touches the manifest...

@jmartinesp
Copy link
Member

It seems like Konsist failed.

Copy link

sonarcloud bot commented Jul 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.14%. Comparing base (f5e866e) to head (ad3c4e1).
Report is 10 commits behind head on develop.

Files Patch % Lines
...droid/x/licenses/OssOpenSourcesLicensesProvider.kt 0.00% 5 Missing ⚠️
...droid/features/preferences/impl/about/AboutView.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3207      +/-   ##
===========================================
- Coverage    76.14%   76.14%   -0.01%     
===========================================
  Files         1644     1645       +1     
  Lines        38768    38783      +15     
  Branches      7501     7503       +2     
===========================================
+ Hits         29521    29531      +10     
- Misses        5350     5355       +5     
  Partials      3897     3897              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 17, 2024
@bmarty bmarty enabled auto-merge July 17, 2024 16:39
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 17, 2024
@bmarty bmarty merged commit 5e6ac6f into develop Jul 17, 2024
28 of 30 checks passed
@bmarty bmarty deleted the feature/bma/openSourceLicenses branch July 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants