-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generated screen to show open source licenses in Gplay variant #3207
Conversation
For Google Play variant only
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm building a release version locally to check how it looks like!
Same false positives in every single PR that touches the manifest... |
It seems like Konsist failed. |
Quality Gate failedFailed conditions |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3207 +/- ##
===========================================
- Coverage 76.14% 76.14% -0.01%
===========================================
Files 1644 1645 +1
Lines 38768 38783 +15
Branches 7501 7503 +2
===========================================
+ Hits 29521 29531 +10
- Misses 5350 5355 +5
Partials 3897 3897 ☔ View full report in Codecov by Sentry. |
Content
Add a entry point in the About screen to the Activity generated by com.google.android.gms.oss-licenses-plugin to render open source licenses. It was already done the same way on Element Android.
Motivation and context
Be compliant with open source licenses requirements.
Screenshots / GIFs
Tests
Tested devices
Checklist