Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Source licenses: add color for links. #3215

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 18, 2024

Content

Complement for #3207: specify color for links in the theme.

Motivation and context

Nicer colors

Screenshots / GIFs

Before After
image image
image image

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Change For updates to an existing feature label Jul 18, 2024
@bmarty bmarty requested a review from a team as a code owner July 18, 2024 10:19
@bmarty bmarty requested review from jmartinesp and removed request for a team July 18, 2024 10:19
Copy link
Contributor

github-actions bot commented Jul 18, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/j6SbUE

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.14%. Comparing base (0d41788) to head (dcafac0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3215   +/-   ##
========================================
  Coverage    76.14%   76.14%           
========================================
  Files         1645     1645           
  Lines        38809    38809           
  Branches      7516     7516           
========================================
  Hits         29552    29552           
  Misses        5356     5356           
  Partials      3901     3901           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Extract colors to own files and create booleans
@bmarty
Copy link
Member Author

bmarty commented Jul 18, 2024

@jmartinesp I have added another commit to avoid code duplication. I have not seen any regression during my test.

@bmarty bmarty requested a review from jmartinesp July 18, 2024 10:45
Copy link

sonarcloud bot commented Jul 18, 2024

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me too.

@bmarty bmarty merged commit bf3bdbf into develop Jul 18, 2024
26 checks passed
@bmarty bmarty deleted the feature/bma/linkColors branch July 18, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants