Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add private SSH keys and clone submodules in the original repo #3225

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

jmartinesp
Copy link
Member

Content

  • Disable adding private SSH keys and cloning submodules in the CI if the repo isn't this one.
  • Also disable Danger jobs since the fallback GH token won't let any forks write comments in PRs, so the issues can't be reported.

Motivation and context

Most steps on PRs from forks are now broken.

Tests

Fork status: #3223
There should be no change for this PR.

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label Jul 19, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner July 19, 2024 15:15
@jmartinesp jmartinesp requested review from ganfra and removed request for a team July 19, 2024 15:15
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NE38Xr

Copy link

sonarcloud bot commented Jul 19, 2024

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmartinesp jmartinesp merged commit 5eef7c1 into develop Jul 19, 2024
28 checks passed
@jmartinesp jmartinesp deleted the misc/jme/fix-ci-for-forks branch July 19, 2024 15:25
@jmartinesp jmartinesp mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants