Fix CI for forks #3226
Fix CI for forks #3226
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3226 +/- ##
========================================
Coverage 76.13% 76.13%
========================================
Files 1645 1645
Lines 38816 38816
Branches 7520 7520
========================================
Hits 29554 29554
Misses 5361 5361
Partials 3901 3901 ☔ View full report in Codecov by Sentry. |
| @@ -17,7 +17,7 @@ jobs: | |||
| name: Build Enterprise APKs | |||
| runs-on: ubuntu-latest | |||
| # Skip in forks | |||
| if: github.repository == 'element-hq/element-x-android' | |||
| if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'element-hq/element-x-android' }} | |||
There was a problem hiding this comment.
@jmartinesp this is not working as expected, the condition is true for forks wanting to build the main branch for instance. What was the rationale for this change?
CC @yostyle
There was a problem hiding this comment.
I think some jobs were being accidentally run before, but I can't remember, to be honest. We can try reverting to the previous config, or try to tweak this one.
This is what I intended to merge in #3225 🥲