Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests on TimelineItemsSubscriber #3554

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 27, 2024

Content

Add unit tests on TimelineItemsSubscriber, in particular, cover the fix done in #3538.

Motivation and context

Improve code coverage.

Screenshots / GIFs

Tests

  • Should not impact production code.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 27, 2024 15:09
@bmarty bmarty requested review from ganfra and removed request for a team September 27, 2024 15:09
Copy link
Contributor

github-actions bot commented Sep 27, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nSPFKY

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (e21c8d1) to head (f89463c).
Report is 35 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3554   +/-   ##
========================================
  Coverage    82.67%   82.68%           
========================================
  Files         1732     1732           
  Lines        40970    40970           
  Branches      4962     4962           
========================================
+ Hits         33873    33874    +1     
  Misses        5341     5341           
+ Partials      1756     1755    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the PR-Misc For other changes label Sep 27, 2024
Copy link

sonarcloud bot commented Sep 27, 2024

@bmarty bmarty merged commit 29356b9 into develop Oct 2, 2024
26 checks passed
@bmarty bmarty deleted the feature/bma/testEmptyTimeline branch October 2, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants