Upgrade the used JDK in the project to v21

[jmartinesp]

Content

Changes the Gradle config to use JDK 21, and change it in the CI flows too.

Motivation and context

JDK 21 is the new default in Android Studio Ladybug.

Tests

Let's see how the CI behaves.

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5ZcSnd

[bmarty]

Note: I have created #3585 to unblock develop, and partially cherry-picked 29b61ca.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.10%. Comparing base (9f7e4d5) to head (d115c2e).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3582      +/-   ##
===========================================
- Coverage    82.38%   81.10%   -1.28%     
===========================================
  Files         1742     1753      +11     
  Lines        41680    42248     +568     
  Branches      5030     5106      +76     
===========================================
- Hits         34337    34267      -70     
- Misses        5576     6213     +637     
- Partials      1767     1768       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

Note: I have created #3585 to unblock develop, and partially cherry-picked 29b61ca.

What I don't know is how did tests even pass the CI in the previous PRs.

[jmartinesp]

Also, ouch:

It seems like we'll lose almost 2% of coverage.

[jmartinesp]

It seems like some code, *Preview ones mostly, is now taken into account for code coverage. That's odd, the Kover filters may need some tweaks.

[jmartinesp]

It seems like 3977455 fixed the Preview code added to coverage issue, which added lots of untested code because their callback functions would never be called. There's still some coverage regression, but it's now -0.29%, not -1.84%.

[bmarty]

Note: I have created #3585 to unblock develop, and partially cherry-picked 29b61ca.

What I don't know is how did tests even pass the CI in the previous PRs.

#3565 has been merged, then #3554 but the latest was based on an old develop branch. Result is a not compiling develop branch. We may want to mitigate this by enabling merge queue, but this was slowing down the process, and so I prefer to keep it that way and fix issues when they happen, which is quite not frequent, so acceptable.

[bmarty]

Thanks. FTR I had to install JDK21 on my computer:

brew install openjdk@21
sudo ln -sfn /opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk /Library/Java/JavaVirtualMachines/openjdk-21.jdk

I have added 2 cleanup commits, please review!

[jmartinesp]

Thanks. FTR I had to install JDK21 on my computer

Thanks for the tip! This is indeed needed if you aren't using the JDK embedded in AS Ladybug.

Also, thanks for the cleanup!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud