-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency org.matrix.rustcomponents:sdk-android to v0.2.50 #3565
Update dependency org.matrix.rustcomponents:sdk-android to v0.2.50 #3565
Conversation
…g.matrix.rustcomponents-sdk-android-0.x
@@ -343,6 +350,7 @@ class RustTimeline( | |||
} | |||
|
|||
@Throws | |||
@Suppress("UnusedPrivateMember") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this warning suppression here, but maybe it's better to just remove the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, maybe just remove it.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
6b8e2af
to
120f711
Compare
120f711
to
67eecb0
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
We may find a better way to compare data class instance if we need to do more comparison in the future...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3565 +/- ##
========================================
Coverage 82.68% 82.68%
========================================
Files 1732 1732
Lines 40974 40975 +1
Branches 4964 4964
========================================
+ Hits 33878 33880 +2
Misses 5341 5341
+ Partials 1755 1754 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the massive work!
...impl/src/test/kotlin/io/element/android/libraries/roomselect/impl/RoomSelectPresenterTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bmarty for fixing the RoomSummary
assertions!
Quality Gate passedIssues Measures |
NP. It's a bit annoying not having "by default" comparable data class, we will need to find a better/cleaner solution if we need to do this sort of hack at too many places. |
This PR contains the following updates:
0.2.49
->0.2.50
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.