-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge unit, screenshot tests and coverage in a single CI call #3593
Merge unit, screenshot tests and coverage in a single CI call #3593
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3593 +/- ##
===========================================
+ Coverage 81.71% 82.45% +0.73%
===========================================
Files 1751 1746 -5
Lines 41936 42110 +174
Branches 5071 5037 -34
===========================================
+ Hits 34269 34722 +453
+ Misses 5893 5618 -275
+ Partials 1774 1770 -4 ☔ View full report in Codecov by Sentry. |
Code coverage is suddenly back and that scares me. |
- name: 📈Generate kover report and verify coverage | ||
run: ./gradlew :app:koverXmlReportGplayDebug :app:koverHtmlReportGplayDebug :app:koverVerifyAll $CI_GRADLE_ARG_PROPERTIES | ||
- name: ⚙️ Check coverage for debug variant (includes unit & screenshot tests) | ||
run: ./gradlew :tests:uitests:verifyPaparazziDebug :app:koverXmlReportGplayDebug :app:koverHtmlReportGplayDebug :app:koverVerifyAll $CI_GRADLE_ARG_PROPERTIES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see testDebugUnitTest inside?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not needed, the kover tasks already run them. You can check the logs of the GH actions to confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content
In the CI, merge the unit tests, screenshot tests and coverage checks in the same Gradle command to avoid having to check for build/config caches between tasks.
Motivation and context
Reduce test job times in the CI, since they're getting quite high.
Tests
Check if CI times are lower.
Checklist