Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the CI compile and execute all the unit tests. #3617

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 7, 2024

I have noticed that we have test compilation failure that was not detected by the CI.
The first commit should fix this and test execution should not be longer.
Second commit will fix the existing issue.

@bmarty bmarty requested a review from a team as a code owner October 7, 2024 15:21
@bmarty bmarty requested review from ganfra and removed request for a team October 7, 2024 15:21
@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/sNyTmV

Copy link

sonarcloud bot commented Oct 7, 2024

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (ce811bd) to head (23c0dc1).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3617   +/-   ##
========================================
  Coverage    82.67%   82.67%           
========================================
  Files         1736     1736           
  Lines        41199    41199           
  Branches      5001     5001           
========================================
  Hits         34060    34060           
  Misses        5372     5372           
  Partials      1767     1767           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmarty bmarty merged commit dd60eaf into develop Oct 7, 2024
26 checks passed
@bmarty bmarty deleted the feature/testOnCi branch October 7, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants