Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knocking : update create room flow #3804

Merged
merged 16 commits into from
Nov 6, 2024

Update screenshots

2ab6289
Select commit
Loading
Failed to load commit list.
Merged

Knocking : update create room flow #3804

Update screenshots
2ab6289
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 6, 2024 in 0s

82.86% (-0.05%) compared to 98bf685

View this Pull Request on Codecov

82.86% (-0.05%) compared to 98bf685

Details

Codecov Report

Attention: Patch coverage is 77.91165% with 55 lines in your changes missing coverage. Please review.

Project coverage is 82.86%. Comparing base (98bf685) to head (2ab6289).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...id/features/createroom/impl/CreateRoomDataStore.kt 45.45% 16 Missing and 2 partials ⚠️
...eroom/impl/configureroom/ConfigureRoomPresenter.kt 63.15% 11 Missing and 3 partials ⚠️
...createroom/impl/configureroom/ConfigureRoomView.kt 88.37% 7 Missing and 3 partials ⚠️
...eateroom/impl/configureroom/RoomVisibilityState.kt 63.63% 3 Missing and 1 partial ⚠️
...atures/createroom/impl/configureroom/RoomAccess.kt 40.00% 3 Missing ⚠️
...eateroom/impl/configureroom/ConfigureRoomEvents.kt 60.00% 2 Missing ⚠️
...teroom/impl/configureroom/RoomAddressErrorState.kt 33.33% 2 Missing ⚠️
...tures/createroom/impl/configureroom/RoomAddress.kt 66.66% 1 Missing ⚠️
...ibraries/matrix/api/createroom/JoinRuleOverride.kt 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3804      +/-   ##
===========================================
- Coverage    82.91%   82.86%   -0.05%     
===========================================
  Files         1772     1776       +4     
  Lines        44534    44673     +139     
  Branches      5227     5242      +15     
===========================================
+ Hits         36924    37019      +95     
- Misses        5780     5821      +41     
- Partials      1830     1833       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov