-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navigation issue when entering recovery key after navigating from the banner #3961
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3961 +/- ##
========================================
Coverage 83.07% 83.07%
========================================
Files 1791 1791
Lines 45335 45335
Branches 5348 5348
========================================
Hits 37661 37661
Misses 5799 5799
Partials 1875 1875 ☔ View full report in Codecov by Sentry. |
callbacks.forEach { it.onDone() } | ||
} else { | ||
backstack.pop() | ||
when (plugins.filterIsInstance<SecureBackupEntryPoint.Params>().first().initialElement) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer we check the state of the backstack here?
if(backstack.canPop()){
backstack.pop()
} else {
callbacks.forEach { it.onDone() }
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is probably safer: 646b92a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my remark, but both ways are ok, do as you prefer :)
Quality Gate passedIssues Measures |
Content
Motivation and context
Closes #3278
Screenshots / GIFs
Before
EnterRecoveryKeyStuck.mp4
After
EnterRecoveryKeyFixed.mp4
Tests
Previous behavior: screen is stuck with a disabled "Continue" button. Need to close the screen manually
Now: navigating back to the room list, the banner is gone
Tested devices
Checklist