Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer getting wedged in unsendable state #2653

Closed
ara4n opened this issue Apr 5, 2024 · 3 comments
Closed

Composer getting wedged in unsendable state #2653

ara4n opened this issue Apr 5, 2024 · 3 comments
Labels
A-Rich-Text-Editor O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Apr 5, 2024

Steps to reproduce

  1. Roughly once a day, start typing in the composer and discover it doesn’t remove the placeholder text and doesn’t let you send:
    image

Outcome

What did you expect?

a composer that works

Your phone model

No response

Operating system version

No response

Application version

567

Homeserver

No response

Will you send logs?

No
@Velin92 Velin92 added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Rich-Text-Editor T-Defect labels Apr 5, 2024
@ara4n
Copy link
Member Author

ara4n commented Apr 23, 2024 •
edited
Loading

@stefanceriu this is still happening for me on 578 even with RTE turned off, as frequently as ever

stefanceriu added a commit that referenced this issue Apr 23, 2024
@stefanceriu
Attempted fix for #2653 - Reset the TextView delegates on every updat…
9b9deb7 
…e call
@stefanceriu
Copy link
Member

All I can think of is that both editors use the same SwiftUI representable approach and that we might be missing something there. Attempted a fix here, let's see how it goes.

stefanceriu added a commit that referenced this issue Apr 23, 2024
@stefanceriu
Attempted fix for #2653 - Reset the TextView delegates on every updat…
a9708f7 
…e call
stefanceriu added a commit that referenced this issue Apr 23, 2024
@stefanceriu
Revert "Attempted fix for #2653 - Reset the TextView delegates on eve…
c36d548 
…ry update call"

This reverts commit 9b9deb7.
stefanceriu added a commit that referenced this issue Apr 23, 2024
@stefanceriu
Revert "Attempted fix for #2653 - Reset the TextView delegates on eve…
d9b91a5 
…ry update call"

This reverts commit 9b9deb7.
@stefanceriu
Copy link
Member

stefanceriu commented Apr 23, 2024 •
edited
Loading

Disregard my previous comment, the real problem and fix is in #2734

stefanceriu added a commit that referenced this issue Apr 24, 2024
@stefanceriu
Revert "Attempted fix for #2653 - Reset the TextView delegates on eve…
27437af 
…ry update call"

This reverts commit 9b9deb7.
stefanceriu added a commit that referenced this issue Apr 24, 2024
@stefanceriu
Revert "Attempted fix for #2653 - Reset the TextView delegates on eve…
2378bb6 
…ry update call"

This reverts commit 9b9deb7.
@pixlwave pixlwave mentioned this issue Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rich-Text-Editor O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanceriu @ara4n @Velin92