-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permalink Tweaks #2768
Permalink Tweaks #2768
Conversation
Generated by 🚫 Danger Swift against 0361710 |
fa74cc6
to
75fa595
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2768 +/- ##
===========================================
+ Coverage 74.49% 74.62% +0.12%
===========================================
Files 581 581
Lines 40817 40806 -11
===========================================
+ Hits 30407 30451 +44
+ Misses 10410 10355 -55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fix the composer bug by adding IDs to the all of the module AnyViews.
75fa595
to
7aa1d42
Compare
Quality Gate passedIssues Measures |
This PR fixes 2 bugs:
Some of the changes are a follow-up to #2734 by fixing #2653 and #2742 in a different way: Our use of
AnyView
was always slightly risky due to the loss of identity that comes with the type erasure. By manually assigning the module'sid
in our navigation coordinators, SwiftUI is able to deduce that the view has indeed been replaced. This means presenting the same room a second time no longer results in weirdness which was necessary to fix bug #1.