Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalink Tweaks 2 #2766

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Permalink Tweaks 2 #2766

merged 4 commits into from
Apr 29, 2024

Conversation

pixlwave
Copy link
Member

This PR can be reviewed commit-by-commit:

@pixlwave pixlwave requested a review from a team as a code owner April 29, 2024 12:03
@pixlwave pixlwave requested review from Velin92 and removed request for a team April 29, 2024 12:03
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 62c23ef

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 74.84%. Comparing base (aaa8af2) to head (62c23ef).

Files Patch % Lines
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 26.66% 11 Missing ⚠️
...en/View/Timeline/TimelineTableViewController.swift 50.00% 3 Missing ⚠️
...es/Other/HTMLParsing/AttributedStringBuilder.swift 92.85% 1 Missing ⚠️
...creens/RoomScreen/View/Timeline/TimelineView.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2766      +/-   ##
===========================================
- Coverage    74.91%   74.84%   -0.08%     
===========================================
  Files          581      581              
  Lines        40789    40817      +28     
===========================================
- Hits         30558    30549       -9     
- Misses       10231    10268      +37     
Flag Coverage Δ
unittests 62.20% <69.23%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 7c94ed9 into develop Apr 29, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/permalink-tweaks-2 branch April 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants