Add metrics: bridge_matrix_api_calls and …_failed #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
commented
Nov 10, 2021
jaller94
commented
Nov 10, 2021
mautrix/client/api/events.py
Outdated
Comment on lines
19
to
22
| API_CALLS = Counter("bridge_matrix_api_calls", | ||
| "The number of Matrix client API calls made", ("update_type",)) | ||
| API_CALLS_FAILED = Counter("bridge_matrix_api_calls_failed", | ||
| "The number of Matrix client API calls which failed", ("update_type",)) |
There was a problem hiding this comment.
Do these need to be imported in a web endpoint function or does a creation of Counter() already add the metric to a Prometheus endpoint?
There was a problem hiding this comment.
It's magic, you don't need to do anything :)
|
Possible improvements (possibly in another PR, given the urgency):
|
jaller94
commented
Nov 10, 2021
I feel like there has gotta be a way to do this with attributes in python |
Half-Shot
approved these changes
Nov 10, 2021
|
Ah, @jaller94 can you also open this upstream to mautrix as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bridge_matrix_api_callsandbridge_matrix_api_calls_failed