Skip to content

Metrics about all Matrix API calls #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Metrics about all Matrix API calls #4

wants to merge 9 commits into from

Conversation

@jaller94
Copy link

@jaller94 jaller94 commented Nov 17, 2021 •
edited
Loading

Upstream Pull request: mautrix#68

Differences to PR #2

  • This covers all Matrix API calls, not just those in events.js, however, all others have an empty string as the method label.
  • This counts retries as separate API calls. Add metrics about Matrix API events mautrix/python#67 considers retries to be part of the first call.
  • matrix_request_seconds did not have the bridge_ prefix.

@jaller94 jaller94 changed the title Revert "Add metrics: bridge_matrix_api_calls and …_failed" Metrics about all Matrix API calls Nov 17, 2021
@jaller94
Copy link
Author

jaller94 commented Dec 29, 2021

This has been merged upstream. mautrix#68
Closing in favour of pulling upstream.

@jaller94 jaller94 closed this Dec 29, 2021
@jaller94 jaller94 deleted the revert-2-j94/call-metrics branch December 29, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaller94 @tadzik