Skip to content

Port to Gtk4 and Gtk.SourceView5 #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

Conversation

jeremypw
Copy link
Collaborator

No description provided.

kaixoo and others added 21 commits December 21, 2024 18:09
* feat: migrate DocumentView.vala drag-and-drop

Replaced drag_received with drag_begin(Gtk.DragSource).
Replaced Gtk.TargetEntry with GLib.Value

* feat: migrate Sidebar.vala gtk drag-and-drop

* feat: migrate MainWindow.vala Gtk.TargetEntry. TODO: Gdk.EventAny

* feat: migrate Gtk.DragContext in SourceList.vala

---------

Co-authored-by: kaixoo <21697330-kaixoo@users.noreply.gitlab.com>
* First compilable version

* Emulate previous appearance of Plugins view

* Update ci.yml

* Update io.elementary.code.yml

* Bump glib dependency for libpeas-2

* Rename non-functional Flatpak manifest

* Sync checkbutton with plugin loaded on show

* Action when checkbox toggled

* Fix double parenting

* Sort plugins by name

* Use bind_model and factory

* Lose unused entities

* Cleanup and code style

* Fix initial appearance of preferences dialog

* Add some comments

* Lose commented out code

* Make activate and deactivate methods mandatory to implement

* Fix Flatpak build for OS8

* Fix ci.yml

* Add libgit2-glib-1.0-dev to ci.yml

* Split SourceList into one file per class

* Fix changed namespace

* Remove DnD code

* Replace Gdk.EventKey

* Use GestureClick

* Handle showing context menu

* Handle search_entry focus in

* Handle window close request
# Conflicts fixed:
#	src/Widgets/ChooseProjectButton.vala
#	src/Widgets/DocumentView.vala
@jeremypw jeremypw marked this pull request as draft February 26, 2025 11:27
@jeremypw
Copy link
Collaborator Author

@zeebok Thanks for the review. Its a while since I've thought about this. I've corrected that libsoup dependency in CI. I am not sure why this PR is not in draft as there is a lot of migration still to be done on it. I fear the diff is already too big anyway and changes need to be backported to the Gtk3 version where possible first.

@zeebok
Copy link
Contributor

zeebok commented Feb 27, 2025

@zeebok Thanks for the review. Its a while since I've thought about this. I've corrected that libsoup dependency in CI. I am not sure why this PR is not in draft as there is a lot of migration still to be done on it. I fear the diff is already too big anyway and changes need to be backported to the Gtk3 version where possible first.

That's fair. I am trying to make a swap at older PRs across the board, that I know are still relevant, and so here I am lol. The PR has a lot of files but a lot of them are small changes, so I am not sure if it is too big. But I trust you to do things in a smart way, just let me know when I should take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants