Skip to content

Commit

Permalink
style: open source day batch #3
Browse files Browse the repository at this point in the history
Fixes hyperledger-cacti#1352

Signed-off-by: rachel2code <racheldsater@gmail.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
  • Loading branch information
rachel2code authored and petermetz committed Nov 25, 2021
1 parent e0e322c commit 3534783
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class BookshelfDetailPage implements OnInit {
this.log.debug(`BambooHarvest IDs: %o`, this.bambooHarvestIds);
}

onClickFormSubmit(value: any): void {
onClickFormSubmit(value: Bookshelf): void {
this.log.debug("form submitted", value);
this.bookshelf = value;
this.modalController.dismiss(this.bookshelf);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export class ShipmentDetailPage implements OnInit {
this.log.debug(`BambooHarvest IDs: %o`, this.bookshelfIds);
}

onClickFormSubmit(value: any): void {
onClickFormSubmit(value: Shipment): void {
this.log.debug("form submitted", value);
this.shipment = value;
this.modalController.dismiss(this.shipment);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class ShipmentListPage implements OnInit {
this.log.debug(`Fetched Shipment data: %o`, shipments);
}

async clickShowDetail(shipment: Shipment) {
async clickShowDetail(shipment: Shipment): Promise<void> {
this.log.debug("clickShowDetail()", shipment);

const modal = await this.modalController.create({
Expand All @@ -73,7 +73,7 @@ export class ShipmentListPage implements OnInit {
}
}

async clickAddNew() {
async clickAddNew(): Promise<void> {
this.log.debug(`clickAddNew()`);
const modal = await this.modalController.create({
component: ShipmentDetailPage,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@
* Prevents Angular change detection from
* running with certain Web Component callbacks
*/
(window as any).__Zone_disable_customElements = true;
type WindowWithZone = Window &
typeof globalThis & { __Zone_disable_customElements: boolean };
(window as WindowWithZone).__Zone_disable_customElements = true;
2 changes: 1 addition & 1 deletion extensions/cactus-plugin-object-store-ipfs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,6 @@
"@types/express": "4.17.13",
"express": "4.17.1",
"ipfs-core-types": "0.6.1",
"multiformats": "9.4.6"
"multiformats": "9.4.9"
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
// Needed to disable the no-unused-vars check here because the file is full
// of unused method parameters given how this is a mock which doesn't do
// anything for the most part and that's by design.
/* eslint-disable @typescript-eslint/no-unused-vars */
import { CID } from "multiformats/cid";
import {
API as FilesAPI,
ChmodOptions,
Expand Down Expand Up @@ -140,7 +144,7 @@ export class FilesApiMock implements FilesAPI {
public async flush(
ipfsPath: string,
options?: AbortOptions | undefined,
): Promise<any> {
): Promise<CID> {
throw new RuntimeError("Method flush() not implemented");
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ export class IpfsHttpClientMock implements IIpfsHttpClient {
this.dag = {} as DAGAPI;
this.dht = {} as DHTAPI;
this.diag = {} as DiagAPI;
this.files = new FilesApiMock({ logLevel: this.options.logLevel }) as any;
this.files = new FilesApiMock({
logLevel: this.options.logLevel,
}) as FilesAPI;
this.key = {} as KeyAPI;
this.log = {} as LogAPI;
this.name = {} as NameAPI;
Expand Down
7 changes: 1 addition & 6 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -17191,12 +17191,7 @@ multicodec@^1.0.0:
buffer "^5.6.0"
varint "^5.0.0"

multiformats@9.4.6:
version "9.4.6"
resolved "https://registry.yarnpkg.com/multiformats/-/multiformats-9.4.6.tgz#d24b2e313ff3a3f8f48eef771d44fb329a354e56"
integrity sha512-ngZRO82P7mPvw/3gu5NQ2QiUJGYTS0LAxvQnEAlWCJakvn7YpK2VAd9JWM5oosYUeqoVbkylH/FsqRc4fc2+ag==

multiformats@^9.0.0, multiformats@^9.4.1, multiformats@^9.4.2, multiformats@^9.4.5:
multiformats@9.4.9, multiformats@^9.0.0, multiformats@^9.4.1, multiformats@^9.4.2, multiformats@^9.4.5:
version "9.4.9"
resolved "https://registry.yarnpkg.com/multiformats/-/multiformats-9.4.9.tgz#5d3c7cf8dfeef6bda2535d37fd0ac99b10a15046"
integrity sha512-zA84TTJcRfRMpjvYqy63piBbSEdqlIGqNNSpP6kspqtougqjo60PRhIFo+oAxrjkof14WMCImvr7acK6rPpXLw==
Expand Down

0 comments on commit 3534783

Please sign in to comment.