-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: 2021-09-20 linter warnings batch 3 / 26 #1352
Labels
Developer_Experience
good-first-issue
Good for newcomers
good-first-issue-100-introductory
Hacktoberfest
Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Nice-to-Have
vGHC-OSD
Grace Hopper Conference - Open Source Day
Comments
petermetz
added
good-first-issue
Good for newcomers
Nice-to-Have
Developer_Experience
Hacktoberfest
Hacktoberfest participants are welcome to take a stab at issues marked with this label.
good-first-issue-100-introductory
labels
Sep 20, 2021
Hi, I'd like to work on this issue. |
@rachel2code Assigned it to you just now, thank you very much in advance! |
@rachel2code |
rachel2code
added a commit
to rachel2code/cactus
that referenced
this issue
Oct 1, 2021
Submitting fixes for Issue hyperledger-cacti#1352, minus fix for ID 30
rachel2code
added a commit
to rachel2code/cactus
that referenced
this issue
Oct 1, 2021
Submitting fixes for Issue hyperledger-cacti#1352, minus fix for ID 30 Signed-off-by: rachel2code <racheldsater@gmail.com>
rachel2code
added a commit
to rachel2code/cactus
that referenced
this issue
Oct 1, 2021
style: open source day batch hyperledger-cacti#3 Fixes hyperledger-cacti#1352 Signed-off-by: rachel2code <racheldsater@gmail.com>
rachel2code
added a commit
to rachel2code/cactus
that referenced
this issue
Oct 1, 2021
Fixes hyperledger-cacti#1352 Signed-off-by: rachel2code <racheldsater@gmail.com>
rachel2code
added a commit
to rachel2code/cactus
that referenced
this issue
Oct 1, 2021
Fixes hyperledger-cacti#1352 Signed-off-by: rachel2code <racheldsater@gmail.com>
petermetz
pushed a commit
to rachel2code/cactus
that referenced
this issue
Nov 24, 2021
Fixes hyperledger-cacti#1352 Signed-off-by: rachel2code <racheldsater@gmail.com> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
pushed a commit
to rachel2code/cactus
that referenced
this issue
Nov 24, 2021
Fixes hyperledger-cacti#1352 Signed-off-by: rachel2code <racheldsater@gmail.com> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Developer_Experience
good-first-issue
Good for newcomers
good-first-issue-100-introductory
Hacktoberfest
Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Nice-to-Have
vGHC-OSD
Grace Hopper Conference - Open Source Day
style: 2021-09-20 linter warnings batch 3 / 26
Description
As of today (20th of September, 2021) we have 260 linter warnings in the codebase.
A set of issues were created to fix them in increments of 10 warnings at a time. Each group of 10 linter warnings is a batch.
There is a one to one relationship between issues opened on GitHub and batches of 10 linter warnings.
The complete list is attached/linked to all the issues, but every given issue should only include fixes to the corresponding batch of warnings to avoid conflicts with others.
For example if an issue has
1 / 26
in it's title, that's batch number one, meaning that the linter warnings that needs to be fixed in the scope of that task are the ones with IDs of 1 to 10, inclusive, as in 1,2,3,4,5,6,7,8,9,10.For
2 / 26
in the title, that's batch#2
and the corresponding warnings IDs in the main table are therefore: 11,12,13,14,15,16,17,18,19,20.For
3 / 26
in the title, that's batch#3
you get the point...Acceptance Criteria
Full List of Linter Warnings
Important: Do not fix all of these, just a subset of them as per the guidelines in the
Description
section above. Otherwise your pull request might get rejected due to unfixable conflicts.The text was updated successfully, but these errors were encountered: