style: open source day batch 3 #1352 #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel2code
requested review from
jonathan-m-hamilton and
petermetz
as code owners
petermetz
requested changes
Oct 1, 2021
There was a problem hiding this comment.
- Please fix the DCO (click the details button next to the check that was marked failed and it will provide example commands)
- Please amend your git commit message to adhere to the formatting requirements (we require a certain format/structure because of the release automation tooling we have in place that auto-generates change log entries for the releases). My recommended commit message below:
style: open source day batch #3
Fixes #1352 
petermetz
changed the title
petermetz
approved these changes
Oct 1, 2021
|
@rachel2code Oops, the compilation failed with these issues, the compiler provided some (at least semi) helpful messages, but do let me know if you need any help resolving these: https://github.com/hyperledger/cactus/pull/1395/checks?check_run_id=3771850580 |
takeutak
approved these changes
Oct 2, 2021
Fixes hyperledger-cacti#1352 Signed-off-by: rachel2code <racheldsater@gmail.com> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting fixes for Issue #1352, minus fix for ID 30. I am coordinating with another contributor before committing the fix for issue ID 30.