Lint Fixes for Issue hyperledger-cacti#1352

Submitting fixes for Issue hyperledger-cacti#1352, minus fix for ID 30 Signed-off-by: rachel2code <racheldsater@gmail.com>
rachel2code · Oct 1, 2021 · 68592ab · 68592ab
1 parent 6deed6d
commit 68592ab
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 7 deletions.
diff --git a/...example-supply-chain-frontend/src/app/bookshelf/bookshelf-detail/bookshelf-detail.page.ts b/...example-supply-chain-frontend/src/app/bookshelf/bookshelf-detail/bookshelf-detail.page.ts
@@ -79,7 +79,7 @@ export class BookshelfDetailPage implements OnInit {
     this.log.debug(`BambooHarvest IDs: %o`, this.bambooHarvestIds);
   }
 
-  onClickFormSubmit(value: any): void {
+  onClickFormSubmit(value: Bookshelf): void {
     this.log.debug("form submitted", value);
     this.bookshelf = value;
     this.modalController.dismiss(this.bookshelf);

diff --git a/...us-example-supply-chain-frontend/src/app/shipment/shipment-detail/shipment-detail.page.ts b/...us-example-supply-chain-frontend/src/app/shipment/shipment-detail/shipment-detail.page.ts
@@ -77,7 +77,7 @@ export class ShipmentDetailPage implements OnInit {
     this.log.debug(`BambooHarvest IDs: %o`, this.bookshelfIds);
   }
 
-  onClickFormSubmit(value: any): void {
+  onClickFormSubmit(value: Shipment): void {
     this.log.debug("form submitted", value);
     this.shipment = value;
     this.modalController.dismiss(this.shipment);

diff --git a/...cactus-example-supply-chain-frontend/src/app/shipment/shipment-list/shipment-list.page.ts b/...cactus-example-supply-chain-frontend/src/app/shipment/shipment-list/shipment-list.page.ts
@@ -53,7 +53,7 @@ export class ShipmentListPage implements OnInit {
     this.log.debug(`Fetched Shipment data: %o`, shipments);
   }
 
-  async clickShowDetail(shipment: Shipment) {
+  async clickShowDetail(shipment: Shipment):Promise<void>  {
     this.log.debug("clickShowDetail()", shipment);
 
     const modal = await this.modalController.create({
@@ -73,7 +73,7 @@ export class ShipmentListPage implements OnInit {
     }
   }
 
-  async clickAddNew() {
+  async clickAddNew():Promise<void>  {
     this.log.debug(`clickAddNew()`);
     const modal = await this.modalController.create({
       component: ShipmentDetailPage,

diff --git a/examples/cactus-example-supply-chain-frontend/src/zone-flags.ts b/examples/cactus-example-supply-chain-frontend/src/zone-flags.ts
@@ -2,4 +2,6 @@
  * Prevents Angular change detection from
  * running with certain Web Component callbacks
  */
-(window as any).__Zone_disable_customElements = true;
+type WindowWithZone = Window & 
+    typeof globalThis & {__Zone_disable_customElements: boolean };
+(window as WindowWithZone).__Zone_disable_customElements = true;
diff --git a/...us-plugin-object-store-ipfs/src/test/typescript/fixtures/mock/ipfs/ipfs-files-api-mock.ts b/...us-plugin-object-store-ipfs/src/test/typescript/fixtures/mock/ipfs/ipfs-files-api-mock.ts
@@ -140,7 +140,7 @@ export class FilesApiMock implements FilesAPI {
   public async flush(
     ipfsPath: string,
     options?: AbortOptions | undefined,
-  ): Promise<any> {
+  ): Promise<RuntimeError> {
     throw new RuntimeError("Method flush() not implemented");
   }
 

diff --git a/...-plugin-object-store-ipfs/src/test/typescript/fixtures/mock/ipfs/ipfs-http-client-mock.ts b/...-plugin-object-store-ipfs/src/test/typescript/fixtures/mock/ipfs/ipfs-http-client-mock.ts
@@ -119,7 +119,7 @@ export class IpfsHttpClientMock implements IIpfsHttpClient {
     this.dag = {} as DAGAPI;
     this.dht = {} as DHTAPI;
     this.diag = {} as DiagAPI;
-    this.files = new FilesApiMock({ logLevel: this.options.logLevel }) as any;
+    this.files = new FilesApiMock({ logLevel: this.options.logLevel }) as FilesAPI;
     this.key = {} as KeyAPI;
     this.log = {} as LogAPI;
     this.name = {} as NameAPI;