Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Enter is not working on OSX #320

Closed
corporateshark opened this issue Feb 18, 2018 · 5 comments
Closed

Shift+Enter is not working on OSX #320

corporateshark opened this issue Feb 18, 2018 · 5 comments

Comments

@corporateshark
Copy link
Contributor

open !.! should be invoked for any file. But nothing actually happens.

@thinkingerrol
Copy link
Contributor

Confirmed, but I didn't expect Shift+ENTER to open !.!. Plain ENTER does open !.! if you configure it to do so via Commands->File associations menu as explained in #317. Not sure why you expected that behavior - maybe it does so on Windows when the Use Windows registered types option is enabled in System Settings?

@corporateshark
Copy link
Contributor Author

Au contraire!

This is how it goes on Windows:

I have a file association set up as follows: *.apk - adb install -r !.!
Pressing Enter on test.apk yields adb install -r test.apk
Pressing Shift+Enter yields a Windows system dialog asking How do you want to open this file?

Similar "system" behavior can be achieved on OSX via open !.!

@thinkingerrol
Copy link
Contributor

thinkingerrol commented Feb 18, 2018

I see the use case; Shift+Enter is broken on OSX, and the config UI is messy:

  1. we got System Settings->Use Windows registered types checkbox
  2. we got Commands->File associations dialog mentioning some key combinations
  3. Shift+Enter and Ctrl+Alt+Enter are only mentioned in Help

I think 1 should be renamed to Use OS registered types on Shift+Enter and Ctrl+Alt+Enter and moved into Commands->File associations dialog.

But admittedly, I digressed and this moving & renaming should be a different ticket and not even sure if should be implemented in far2l as opposed to FarGroup/FarManager unless what elfmz said in #14 no longer holds and his elfmz/far2l is ready to diverge.

True way to better world is making world better, but not making better [worlds].

OTOH, far2l seems already diverged in being based on v2 of FarManager. I wonder, why.

P.S.
In bootstrap/scripts/FarEng.hlf.m4 it says:

Execute, change folder, enter to an archive                  #Enter#
Execute in the separate window                         #Shift-Enter#
Execute as administrator                            #Ctrl-Alt-Enter#
...
    You may add new associations with the #Edit associations# command in the
~Commands menu~@CmdMenu@.
...
   If no execute command is associated with file and
#Use Windows registered types# option in ~System settings~@SystemSettings@
is on, FAR tries to use Windows association to execute this file type;

elfmz added a commit that referenced this issue Feb 23, 2018
@elfmz
Copy link
Owner

elfmz commented Feb 23, 2018

check, it should be better now

@corporateshark
Copy link
Contributor Author

Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants