Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keyboard navigation #1885

Closed
wants to merge 2 commits into from
Closed

fix: keyboard navigation #1885

wants to merge 2 commits into from

Conversation

ThaddeusJiang
Copy link
Contributor

@ThaddeusJiang ThaddeusJiang commented Apr 4, 2024 •
edited
Loading

Sorry, It is still work in progress.

  • Fix the left and right arrow navigation. The right arrow should expand, and the left arrow should close, whereas currently they both just toggle

CleanShot 2024-04-04 at 23 04 50

  • The buttons displayed doesn't do anything on click

CleanShot 2024-04-05 at 14 14 36

  • Use postMessage. The iframe should start as hidden and we should only show the iframe once it uses postMessage. The postMessage should include the content height, so we can render the maximum iframe height accordingly

@ThaddeusJiang
Fix the left and right arrow navigation. The right arrow should expan…
45752b4 
…d, and the left arrow should close, whereas currently they both just toggle
@ThaddeusJiang ThaddeusJiang changed the title search preview WIP: search preview Apr 4, 2024
@mudssrali mudssrali mentioned this pull request Apr 4, 2024
Merged
3 tasks
@josevalim josevalim changed the base branch from main to search-preview April 4, 2024 15:13
@josevalim
Copy link
Member

Thank you @ThaddeusJiang! I changed your branch to merge against search-preview. Let me know when this is ready to merge. :)

@arathunku arathunku mentioned this pull request Apr 5, 2024
Closed
@ThaddeusJiang
Copy link
Contributor Author

Let me know when this is ready to merge. :)

@josevalim ok, I will continue.

@josevalim
Copy link
Member

@ThaddeusJiang we don't need to tackle everything in one PR. So I will merge the functionaltiy for now and the iframe can be in a follow up one. :)

@josevalim
Copy link
Member

I have merged this locally and I will push soon! 💚 💙 💜 💛 ❤️

@josevalim josevalim closed this Apr 5, 2024
@ThaddeusJiang ThaddeusJiang deleted the search-preview branch April 5, 2024 11:48
@ThaddeusJiang ThaddeusJiang changed the title WIP: search preview fix: keyboard navigation Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThaddeusJiang @josevalim