Skip to content

feat: render the maximum iframe height accordingly #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2024
Merged

feat: render the maximum iframe height accordingly #1888

merged 1 commit into from
Apr 8, 2024

Conversation

ThaddeusJiang
Copy link
Contributor

@ThaddeusJiang ThaddeusJiang commented Apr 8, 2024 •
edited
Loading

  • Use postMessage. The iframe should start as hidden and we should only show the iframe once it uses postMessage. The postMessage should include the content height, so we can render the maximum iframe height accordingly

CleanShot 2024-04-08 at 18 45 37

@josevalim josevalim merged commit 3e6ea37 into elixir-lang:search-preview Apr 8, 2024
@ThaddeusJiang ThaddeusJiang deleted the feat/iframe-height branch April 8, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThaddeusJiang @josevalim