Skip to content

Add support for relay candidates #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Add support for relay candidates #33

merged 5 commits into from
Apr 15, 2024

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Apr 3, 2024

closes #9
related to #8

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #33 (d1517bb) into master (1b57c79) will increase coverage by 2.22%.
Report is 2 commits behind head on master.
The diff coverage is 82.34%.

❗ Current head d1517bb differs from pull request most recent head d81b178. Consider uploading reports for the commit d81b178 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   77.97%   80.20%   +2.22%     
==========================================
  Files          20       25       +5     
  Lines        1049     1283     +234     
==========================================
+ Hits          818     1029     +211     
- Misses        231      254      +23     
Files Coverage Δ
lib/ex_ice/candidate.ex 81.25% <100.00%> (-0.81%) ⬇️
lib/ex_ice/priv/app.ex 100.00% <100.00%> (ø)
lib/ex_ice/priv/attribute/ice_controlled.ex 75.00% <ø> (ø)
lib/ex_ice/priv/attribute/ice_controlling.ex 75.00% <ø> (ø)
lib/ex_ice/priv/attribute/priority.ex 75.00% <ø> (ø)
lib/ex_ice/priv/attribute/use_candidate.ex 75.00% <ø> (ø)
lib/ex_ice/priv/candidate.ex 100.00% <100.00%> (ø)
lib/ex_ice/priv/checklist.ex 100.00% <100.00%> (ø)
lib/ex_ice/priv/dns/message.ex 74.54% <ø> (ø)
lib/ex_ice/priv/gatherer.ex 95.12% <100.00%> (ø)
... and 15 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d100eb9...d81b178. Read the comment docs.

@mickel8 mickel8 mentioned this pull request Apr 12, 2024
63 tasks
@mickel8 mickel8 marked this pull request as ready for review April 15, 2024 13:20
@mickel8 mickel8 merged commit 78a3218 into master Apr 15, 2024
@mickel8 mickel8 deleted the relay-cand branch April 15, 2024 13:21
@mickel8 mickel8 mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support local realy candidates (TURN servers)
1 participant