Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Drop elm- prefix from libraries #27

Closed
mgold opened this issue May 14, 2016 · 20 comments
Closed

Proposal: Drop elm- prefix from libraries #27

mgold opened this issue May 14, 2016 · 20 comments

Comments

@mgold
Copy link
Member

mgold commented May 14, 2016

elm-commity/elm-random-extra, for example, has elm in it twice. This convention was established before the community came along, and we wanted to be clear on our personal GitHub pages what the library we had created was for. Under elm-community, one assumes to find only Elm things, so it seems unnecessary.

Migrating is going to be a real pain - maybe it waits for 0.18 - but if I could wave a magic wand and remove the elm- prefix without any kind of legacy pain, would it be a good idea?

@JoeyEremondi
Copy link
Member

My main hesitation is that this makes it awkward for anyone who forks a
project. It's clear what random is in Elm-community, but if I want to do a
PR, I now have JoeyEremondi/random in my personal github.
On May 13, 2016 6:53 PM, "Max Goldstein" notifications@github.com wrote:

elm-commity/elm-random-extra, for example, has elm in it twice. This
convention was established before the community came along, and we wanted
to be clear on our personal GitHub pages what the library we had created
was for. Under elm-community, one assumes to find only Elm things, so it
seems unnecessary.

Migrating is going to be a real pain - maybe it waits for 0.18 - but if I
could wave a magic wand and remove the elm- prefix without any kind of
legacy pain, would it be a good idea?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#27

@jvoigtlaender
Copy link
Contributor

I agree with Max. Joey, you have the same problem with elm-lang/core, elm-lang/html etc.

@JoeyEremondi
Copy link
Member

Very true, and I think it's even possible to change the repo name when you
fork. +1

On Fri, May 13, 2016 at 10:03 PM, Janis Voigtländer <
notifications@github.com> wrote:

I agree with Max. Joey, you have the same problem with elm-lang/core,
elm-lang/html etc.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#27 (comment)

@jvoigtlaender
Copy link
Contributor

Actually: Why wait for 0.18? So far only 5 elm-community packages have been published in 0.17 versions. So maybe it's not too late to make the general name transition now for 0.17.

@mgold
Copy link
Member Author

mgold commented May 14, 2016

Okay, I'd like to wait for a few more people to weigh in, but I'm glad you two like the idea and I'll hold off publishing my e-c libs.

@lukewestby
Copy link

lukewestby commented May 14, 2016

this sounds good to me, seeing elm- in front of every elm package ever is getting a little redundant

@ThomasWeiser
Copy link

I am also in favor of removing the tautologous elm- prefixes.

@fredcy
Copy link
Member

fredcy commented May 16, 2016

Sounds good to me.

@abadi199
Copy link
Member

I'm also in favor of removing the elm- prefixes, and we should just do it now for all unpublished packages, and for the one already published we can do what @rtfeldman suggested on slack channel

@jvoigtlaender
Copy link
Contributor

@abadi199, can you repeat here what the suggestion on the slack channel was? Or is it a secret? 😄

@fredcy
Copy link
Member

fredcy commented May 17, 2016

I believe this is the Slack conversation being referenced:

screen shot 2016-05-17 at 8 55 09 am

@abadi199
Copy link
Member

Sorry, yes that's the slack conversation I was referring to.

@fredcy
Copy link
Member

fredcy commented May 20, 2016

For packages already published such as elm-linear-algebra, are we to create a new renamed repo as a copy per rtfeldman's directions just above? If so, should we re-publish all the same versions?

@fredcy
Copy link
Member

fredcy commented May 20, 2016

See also elm-community/elm-linear-algebra#12

@lukewestby
Copy link

waiting on feedback to @fredcy's comments above for elm-community/elm-json-extra#11 as well

@abadi199
Copy link
Member

abadi199 commented May 23, 2016

I also need to know what to do for elm-community/elm-list-extra#43

I'm suggesting to add

DEPRECATED: Renamed to http://package.elm-lang.org/elm-community/[new-package-name]

to the Readme of the old package, and create a new repo with the new name, and reset the version to 1.0.0

Also need to set the elm-package.json summary with the deprecate message so that it shows up in the search results summary in package.elm-lang.org.

e.g.:

{
    "version": "x.x.x",
    "summary": "DEPRECATED: Renamed to http://package.elm-lang.org/elm-community/[new-package-name]"
}

@jvoigtlaender
Copy link
Contributor

Seems only one repository is left un-renamed: https://github.com/elm-community/elm-material-icons

After that, this issue could be closed @mgold?

@eeue56
Copy link
Contributor

eeue56 commented Dec 21, 2016

@mgold ping

@mgold
Copy link
Member Author

mgold commented Dec 22, 2016

Sorry! Will try to get to this.

@mgold
Copy link
Member Author

mgold commented Dec 25, 2016

Done!

@mgold mgold closed this as completed Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants