This repository has been archived by the owner on Feb 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
added String modifier to parse-string #29
Open
andre-dietrich
wants to merge
58
commits into
elm-community:master
Choose a base branch
from
andre-dietrich:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check failed because of:
see the travis output and not because of the new function ... |
If you replace the current contents of language: elm I think the tests should run properly :) |
* Most importantly: `Int` was failing _with expected an Float_ * Also, _expected whitespace_ for `\s*` was perhaps misleading, so changed to _expected optional whitespace_ (even though this will probably never fail 😁) * Others fixed for better consistency / English
Improve some parser failure messages
Just curious, what is the status on this one? |
- alpha: checks for Char.isAlpha - alphaNum: checks for Cahr.isAlphaNum
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it took a while, but I had added one function
modifyStream
that can be used to inject strings into the parse string. I use it to define statefull macros, that inject code at compile time into the code while parsing. See, https://liascript.github.io ...It would be great, if you could add this simple function, so that I could switch back to your repo in my project.
Regards
André