-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add prettier as formatter #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcalexiei Changes reviewed - don't worry about my comment on updating prettier config to favor single quotes - if you have the time to do soon you can, otherwise I'll merge your changes after you address my other comments and then we can update the prettier config at a later time.
All review comments should have been addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good. Merging.
@marcalexiei Hey, your changes are good (thanks for them), though note: coverage went down for |
The PR is not merged so I assume is better that I fix the coverage issue here... |
No, it's ok - You can do it in your next PR |
Part of #141
prettier
has been added as formatter and all relevant code has formatted.build-and-test.yml
workflow has been renamed to CI because now it also includesformat
check