-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] Add Airflow provider package catalog connector #2416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speed up reading of component definition by parallelizing associated method calls for each path in a registry and some minor refactoring of component registry related functions
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
6 tasks
2 tasks
Co-authored-by: Martha Cryan <martha.cryan@ibm.com>
Clarification based on today's discussion in the dev meeting. The proposed PR implementation is based on the following assumptions:
|
* Unpin click dependency * Restore floor for click
Will redo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind:enhancement
New feature or request
platform: pipeline-Airflow
Related to usage of Apache Airflow as pipeline runtime
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a catalog connector for Apache Airflow provider packages. Connector instances require the user to configure a download URL for the Apache Airflow provider package that is installed in the cluster.
Requires #2418, #2409
What changes were proposed in this pull request?
catalog-connectors
directory to the repository root, containing in theairflow
subdirectory the newly introduced connectorMakefile
to include newlint-connectors
target, which was also added as a dependency to thelint
tasklint-connectors
task to Github'sbuild.yaml
Notes:
apache_airflow_providers_ssh
- see later comment) and Python file name (e.g.airflow/providers/ssh/operators/ssh.py
) as hash keys, which are used to internally identify operators in the palette.2.3.0-py3-none-any
, is currently not part of the key to avoid potential versioning issues. For example, assume user A adds operators from archive...2.3.0-py3-none-any
to the Elyra deployment and creates a pipeline using some of the operators. User B adds operators from an older archive, such as...2.2.0-py3-none-any
. If we were to include the archive name as is as a key, user B would not be able to run pipelines that user A created (and vice versa) because (pseudo code)How was this pull request tested?
Unit testing included the providers listed in this discussion thread
Notes:
There are unresolved Elyra Airflow component parser issues that need to be addressed before the Airflow 1.10.15 package can be used.Improve Airflow parser functionality #2418Developer's Certificate of Origin 1.1