Add support for schema validators #2829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for schema validators after learning that the default
validate()
method injsonschema
can leak memory when called repeatedly. (See #2826 for details)Aside from using the
Draft7Validator
by default, we also expose the ability forSchemasProvider
implementors to bring their own validators as part of their provider.Rather than create a validator instance whenever validation is required (as was done in the results for #2826), the
SchemaManager
captures the validator's instance upon loading theSchemasProvider
. By doing this, the overall test time went from 16 seconds to 2 seconds, thereby gaining an overall 50X performance improvement over using the defaultvalidate()
method done originally.Resolves: #2826
Developer's Certificate of Origin 1.1