Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a "first pass" at addressing the warnings produced following the server CI tests. Prior to this PR
3791
warnings were produced. This PR takes the warnings down to474
(87%) and when merged with #2829, the warnings will be around55
(98%). (Note, these values were produced on my local dev env. In running CI on my fork, and without #2829, I still see2108
warnings, but474
on my local system. I suspect the additional warnings are related to recent deprecations intornado
regarding event loop management and I'm running with an older version.)The primary issue here was in handling class initialization parameters within the
Configurable
class hierarchy. The PR currently has two commits, each taking a different approach to resolving the issue.root_dir
) so that it is not included in the**kwargs
that flow to the superclasses. This approach probably consisted of fewer changes than the second because that was closer to what was happening before.**kwargs
but pop parameters likeroot_dir
out, so that it doesn't interfere in the superclasses. This approach was chosen because I found it was used within thetraitlets
package, lending credence to that approach.I also refactored the
PipelineProcessorResponse
class, introducing aRuntimePipelineProcessorResponse
class. The KFP and Airflow response objects derive from the latter while the Local response object derives directly fromPipelineProcessorResponse
since it doesn't need the location information in the response and was just passing empty string placeholders for those values. In addition, this class hierarchy now mirrors that of thePipelineProcessor
class hierarchy.In some cases, you'll see the
__init__()
method completely removed. This is intentional as it is not required if the traitlet (e.g.,root_dir
) is the only item needed from the**kwargs
and is functionality thetraitlets
package provides automatically.I'm going ahead and marking #2782 as resolved by this PR since most all of the remaining errors can be attributed to upstream components (Tornado, KFP, and Papermill) and should probably be addressed with separate issues for each.
Resolves: #2782
Developer's Certificate of Origin 1.1