-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make multi-valued input fields more user-friendly #2927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 19 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 19 potential problems in the proposed changes. Check the Files changed tab for more details.
Currently properties for custom nodes are visually grouped into categories:
We should do the same for generic nodes (either in this PR or a follow-up). Doing so would provide for a more uniform user experience and prepare for the migration of the current one-off implementation to one that utilize a genuine custom component to run noteboooks and scripts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 19 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 19 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 15 potential problems in the proposed changes. Check the Files changed tab for more details.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 15 potential problems in the proposed changes. Check the Files changed tab for more details.
…201) Addresses issues in elyra-ai/elyra#2927 Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 15 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 15 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very nice work. Gone are the days of esoteric input!
just pushed to update to point at the RC release of pipeline editor now that elyra-ai/pipeline-editor#201 is merged and released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 15 potential problems in the proposed changes. Check the Files changed tab for more details.
Fixes #2750
Fixes #2738
Fixes #2923
Fixes #2906
Corresponds to elyra-ai/pipeline-editor#201.
Excuse all the extraneous commits - I was building and merging with the
pipeline-rjsf
branch so often and for so long that I didn't want to mess with the history by cherry-picking. The diff, however, is accurate.Note that the pipeline editor may go blank when trying to edit multi-valued fields at this point during development. Front end changes required before things are fully functional.
What changes were proposed in this pull request?
This PR re-factors a significant portion of backend node and pipeline properties handling in order to centralize and simplify validation and processing of Elyra-owned properties (which includes properties such as
mounted_volumes
,kubernetes_secrets
, etc. that are not properties considered a part of the operator/component definition itself).TODOs:
frontend: frontend validation (may require schema updates on backend)backend validation will handle most cases; frontend validation can be added in a follow-up if requiredfrontend/backend: investigate improving display of Component Source property (Add a control for dictionary types in the node properties panel #2256) (may be better tackled in a follow-up PR)non-trivial, will have to tackle in a follow-upHow was this pull request tested?
make docs
(section "Node properties reference" in the pipelines documentation topic)Manual test checklist. If checked, end-to-end test was successful:
.pipeline
filepipeline properties:
node properties (KFP)
node properties (Airflow)
Developer's Certificate of Origin 1.1