Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arrays of multi-valued fields in pipeline properties #201

Merged
merged 8 commits into from
Sep 27, 2022

Conversation

marthacryan
Copy link
Member

Added to address issues in elyra-ai/elyra#2927.

image

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #201 (8977a75) into main (b9021eb) will decrease coverage by 1.31%.
The diff coverage is 15.51%.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   62.85%   61.53%   -1.32%     
==========================================
  Files          46       46              
  Lines        1642     1682      +40     
  Branches      471      483      +12     
==========================================
+ Hits         1032     1035       +3     
- Misses        484      516      +32     
- Partials      126      131       +5     
Impacted Files Coverage Δ
...es/pipeline-editor/src/PipelineController/index.ts 57.94% <4.54%> (-2.45%) ⬇️
...pipeline-services/src/migration/migrateV8/index.ts 46.87% <11.76%> (-41.37%) ⬇️
...line-editor/src/CustomFormControls/CustomArray.tsx 33.33% <23.52%> (-8.34%) ⬇️
packages/pipeline-editor/src/NodeTooltip/utils.ts 100.00% <100.00%> (ø)
packages/pipeline-services/src/migration/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ajbozarth
Copy link
Member

I've added the migration update, but I still need to update the tests to include the new migration case

@ajbozarth ajbozarth closed this Sep 22, 2022
@ajbozarth ajbozarth reopened this Sep 22, 2022
@ajbozarth ajbozarth changed the title Add pipeline defaults for object arrays in node properties editor Add support for multi-valued fields in pipeline properties Sep 27, 2022
@ajbozarth ajbozarth changed the title Add support for multi-valued fields in pipeline properties Add support for arrays od multi-valued fields in pipeline properties Sep 27, 2022
@ajbozarth ajbozarth changed the title Add support for arrays od multi-valued fields in pipeline properties Add support for arrays of multi-valued fields in pipeline properties Sep 27, 2022
@ajbozarth ajbozarth merged commit 0565d84 into elyra-ai:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants