-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite KFP code generation #2993
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
""" | ||
# Load Kubeflow Pipelines Python DSL template | ||
loader = PackageLoader("elyra", "templates/kubeflow") | ||
template_env = Environment(loader=loader) |
Check warning
Code scanning / CodeQL
Jinja2 templating with autoescape=False
- Missing input data type - Where necessary use quotes around values - Fix incorrect debug statement
generic_component_template = Environment( | ||
loader=PackageLoader("elyra", "templates/kubeflow/v1") | ||
).get_template("generic_component_definition_template.jinja2") |
Check warning
Code scanning / CodeQL
Jinja2 templating with autoescape=False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits, CRIO options look right and exported configs (volumes and modified bootstrapper options) look good.
Co-authored-by: Alan Chin <akchin@us.ibm.com>
Based on a discussion we've had during today's dev meeting, I've updated code generation to "unload" the generated Python DSL module after it was compiled. This change should address the potential concern that over time module artifacts might accumulate, which could lead to increased memory consumption over long periods of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this is awesome! Tested a ton of scenarios and all are turning out as expected 🎉
Co-authored-by: Kiersten Stokes <kierstenstokes@gmail.com>
Co-authored-by: Kiersten Stokes <kierstenstokes@gmail.com>
To address offline review feedback I've updated the Python DSL template to render a comment that identifies the node name:
This is similar to what is done for Apache Airflow |
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
This PR:
format
parameter to theelyra-pipeline export
CLI command:YAML
/PY
(Kubeflow Pipelines) orPY
(Airflow)Closes #2986
Follow-up for tests: #3002
What changes were proposed in this pull request?
The Kubeflow Pipelines processor now always generates Python DSL code as intermediary output when a pipeline is submitted or exported:
How was this pull request tested?
make docs
Developer's Certificate of Origin 1.1