fix: change from deprecated ipfs-api to ipfs-http-client #1535
Conversation
|
Awesome! We've bee needing to do this for quite some time, thanks for taking care of it. |
| @@ -1,4 +1,4 @@ | |||
| const IpfsApi = require('ipfs-api'); | |||
| const IPFS = require('ipfs-http-client'); | |||
There was a problem hiding this comment.
One small thing, not really a PR blocker. Usually in .js and .ts all caps is used for constants, so it might be a little confusing to have a "library variable" that looks like a constant later on in the code.
There was a problem hiding this comment.
I'm using all constants because IPFS is an acronym, like HTTP and TCP. This is also, technically, a constant 😉
There was a problem hiding this comment.
I'd go with Michael here. I'd even rename it ipfsClient so it's clear what it is.
andremedeiros
force-pushed
the
fix/ipfs-package
branch
from
aaa3155 to
7f58ccb
Compare
|
DO NOT MERGE. This version of |
jrainville
left a comment
jrainville
left a comment
There was a problem hiding this comment.
Nice job.
This will need changes in the website too probably.
| @@ -1,4 +1,4 @@ | |||
| const IpfsApi = require('ipfs-api'); | |||
| const IPFS = require('ipfs-http-client'); | |||
There was a problem hiding this comment.
I'd go with Michael here. I'd even rename it ipfsClient so it's clear what it is.
| } | ||
|
|
||
| this.events.emit('runcode:register', 'IpfsApi', require('ipfs-api'), () => { | ||
| this.events.emit('runcode:register', 'IPFS', require('ipfs-http-client'), () => { |
There was a problem hiding this comment.
This breaks embarkjs-ipfs which relies on the variable IpfsAPI
|
PR was submitted to the ipfs team: ipfs-inactive/js-ipfs-http-client#996. |
|
The PR was merged and a new version of package |
No description provided.