build: change min node version to 8.3.0 #996
Conversation
Also adjust Travis CI config to perform builds and tests with node 8. `npm install`, `npm run build`, and `npm run test` all succeeded locally with node version `8.3.0`. The reason for version `8.3.0` instead of `8.0.0` is that `8.3.0` introduced support for object rest/spread, which is used by at least one of this package's devDependencies (`go-ipfs-dep`). It may be the case that at runtime older versions of node would work correctly with the built package, but it seems simpler to settle on the minimum supported version being a version that can build, test, and use the package. Closes ipfs-inactive#983.
michaelsbradleyjr
force-pushed
the
build/node-8
branch
from
a124650 to
cef7890
Compare
|
I'm not sure how to adjust the Travis CI config so that tests are run with node version 8 on Windows. I'm also not sure, if this PR is to be merged, whether it should include changes to the README indicating that the Maintenance LTS of node is also supported. |
|
@alanshaw @michaelsbradleyjr There is again problem with support for Node.js 8. It now fails because of |
|
@filips123, indeed. The problem is especially apparent when you use So, in hindsight, this PR was actually mostly pointless and should probably be reverted (@alanshaw). |
Also adjust Travis CI config to perform builds and tests with node 8.
npm install,npm run build, andnpm run testall succeeded locally with node version8.3.0.The reason for version
8.3.0instead of8.0.0is that8.3.0introduced support for object rest/spread, which is used by at least one of this package's devDependencies (go-ipfs-dep, in production install of that devDep). It may be the case that at runtime older versions of node would work correctly with the built package, but it seems simpler to settle on the minimum supported version being a version that can build, test, and use the package.Closes #983.