This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Should the required NodeJS version be >=8.0.0? #983
Comments
michaelsbradleyjr
changed the title
|
ping |
1 similar comment
|
ping |
|
This is not a priority for us as we've decided our minimum supported version is Node.js 10. That said, I see no reason to deny Node.js 8 users from installing if it is still compatible, so if you're willing to help @andremedeiros with #937 (comment) that would be amazing. |
|
Sounds great, thanks. |
michaelsbradleyjr
added a commit
to michaelsbradleyjr/js-ipfs-http-client
that referenced
this issue
May 14, 2019
Also adjust Travis CI config to perform builds and tests with node 8. `npm install`, `npm run build`, and `npm run test` all succeeded locally with node version `8.3.0`. The reason for version `8.3.0` instead of `8.0.0` is that `8.3.0` introduced support for object rest/spread, which is used by at least one of this package's devDependencies (`go-ipfs-dep`). It may be the case that at runtime older versions of node would work correctly with the built package, but it seems simpler to settle on the minimum supported version being a version that can build, test, and use the package. Closes ipfs-inactive#983.
alanshaw
pushed a commit
that referenced
this issue
May 15, 2019
Also adjust Travis CI config to perform builds and tests with node 8. `npm install`, `npm run build`, and `npm run test` all succeeded locally with node version `8.3.0`. The reason for version `8.3.0` instead of `8.0.0` is that `8.3.0` introduced support for object rest/spread, which is used by at least one of this package's devDependencies (`go-ipfs-dep`). It may be the case that at runtime older versions of node would work correctly with the built package, but it seems simpler to settle on the minimum supported version being a version that can build, test, and use the package. Closes #983.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See: #937 (comment).
The text was updated successfully, but these errors were encountered: