Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin ember-qunit to 5.0.0. #234

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Pin ember-qunit to 5.0.0. #234

merged 2 commits into from
Feb 4, 2021

Commits on Feb 4, 2021

  1. Pin ember-qunit to 5.0.0. 

    ember-qunit@5.1.0 introduces a new axe-core failure:

```
Error: The page should have no accessibility violations. Violations:
[moderate]: Ensure that scrollable region has keyboard access
Violated 1 time. Offending nodes are:
<div id="ember-testing-container" style="visibility: visible; position:
relative;">
```

This gets CI passing again (the floating dependencies tests at least),
we will have to unpin as soon as possible but this should unblock other
bug fixes.
    @rwjblue
    rwjblue committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    34e0899 View commit details
    Browse the repository at this point in the history

  2. Increase number of expected axe-core violations by default.

    @rwjblue
    rwjblue committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    9125c64 View commit details
    Browse the repository at this point in the history