Pin ember-qunit to 5.0.0. #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
This is likely introduced by emberjs/ember-qunit#786. |
rwjblue
force-pushed
the
pin-ember-qunit
branch
from
ccc699b
to
6476b9d
Compare
ember-qunit@5.1.0 introduces a new axe-core failure: ``` Error: The page should have no accessibility violations. Violations: [moderate]: Ensure that scrollable region has keyboard access Violated 1 time. Offending nodes are: <div id="ember-testing-container" style="visibility: visible; position: relative;"> ``` This gets CI passing again (the floating dependencies tests at least), we will have to unpin as soon as possible but this should unblock other bug fixes.
rwjblue
force-pushed
the
pin-ember-qunit
branch
from
6476b9d
to
34e0899
Compare
scalvert
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-qunit@5.1.0 introduces a new axe-core failure:
This gets CI passing again (the floating dependencies tests at least), we will have to unpin as soon as possible but this should unblock other bug fixes.