Unpin ember-qunit, fix testing container CSS overrides #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to PRs #234 and emberjs/ember-qunit#817.
Now that the ember testing container issues have been resolved, it is no longer necessary to pin
ember-qunitto v5.0.0. I've taken this opportunity to also bumpaxe-coreto the latest version (4.1.2) and fix the a11y related container CSS styles so that test results are consistent between standard and fullscreen modes. (I'm not entirely sure how these were even working properly before with thestaticCSS positioning.)Verified all tests pass and no regressions have been introduced by running these changes through several apps that are actively using the addon.