Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved positioning of test container to go with qunit/pull/#1513 #786

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

BryanCrotaz
Copy link
Contributor

Pairs with qunitjs/qunit#1513 to make for a better dev experience when more than a screenful of tests is run.

Merely a css update

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BryanCrotaz!

@rwjblue rwjblue merged commit 27adee7 into emberjs:master Dec 5, 2020
@BryanCrotaz BryanCrotaz deleted the improve-testing-ui branch December 5, 2020 19:25
@BryanCrotaz
Copy link
Contributor Author

😇

@BryanCrotaz
Copy link
Contributor Author

Can we get a 4.6.1 release with some of the 270 fixes like this one since 4.6.0 until v5 is ready?

@rwjblue
Copy link
Member

rwjblue commented Dec 7, 2020

I'll be releasing 5.0.0 tomorrow when I'm back at my computer.

@BryanCrotaz BryanCrotaz restored the improve-testing-ui branch December 10, 2020 11:07
@Turbo87
Copy link
Member

Turbo87 commented Jan 19, 2021

@BryanCrotaz how is this different from the "Dock Container" option now? the default style and the docked style now appear to be essentially identical and both get in the way of reading the test names in some cases 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants