Update to QUnit 2.0 compatible output. #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2015
| @@ -9,7 +9,7 @@ moduleFor('adapter:<%= dasherizedModuleName %>', '<%= classifiedModuleName %>Ada | |||
| }); | |||
|
|
|||
| // Replace this with your real tests. | |||
| test('it exists', function() { | |||
| test('it exists', function(assert) { | |||
There was a problem hiding this comment.
Does this and the other places need to be QUnit.test ?
There was a problem hiding this comment.
Test is imported from ember-qunit here, so no.
|
You missed a lot of |
See http://qunitjs.com/upgrade-guide-2.x/ for more details.
rwjblue
force-pushed
the
update-to-qunit-2-0-compat
branch
from
b1c0572
to
c35e358
Compare
|
Restarting travis but looks good to me. |
rwjblue
force-pushed
the
update-to-qunit-2-0-compat
branch
from
a7568ee
to
4c7a8fc
Compare
rwjblue
added a commit
that referenced
this pull request
Feb 4, 2015
Update to QUnit 2.0 compatible output.
clekstro
added a commit
to fauxton/travis-web
that referenced
this pull request
Jan 31, 2016
As noted in [this issue](ember-cli/ember-cli#3197), assert is now to be prepended to assertions and passed in to the test function. This commit was generated by ember-watson.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://qunitjs.com/upgrade-guide-2.x/ for more details.
Closes #3196.