Update QUnit hook names: setup/teardown is deprecated for beforeEach/afterEach

[EndangeredMassa]

QUnit has deprecated setup/teardown in favor of beforeEach/afterEach. So, the documentation recommends beforeEach/afterEach.

Ember.js still refers to setup/teardown in many places. This lead to a lot of confusion for us recently. Can we update all references from setup/teardown to beforeEach/afterEach?

Here are the references I found:

• Ember.js Test Helper Documentation
• ember-cli Documentation
• ember-qunit code
• In Many ember-cli Test Blueprints

I know it seems like a lot to change for no functional difference, but please keep in mind that:

1. The terms setup/teardown are confusing. In other test libraries, they only run once per module/context/etc instead of once per test.
2. QUnit officially deprecated setup/teardown and they will be removed in QUnit 2.0.

[rwjblue]

👍 - Would happily accept a PR.

[rwjblue]

Also related: ember-cli/ember-cli-qunit#19

[EndangeredMassa]

Awesome. I just wanted to check before changing it everywhere.

[rwjblue]

Ya, but we need to detect which to use I think. Because we should support both QUnit 1.15 and 1.16.

[EndangeredMassa]

Definitely. I think it might also be helpful to detect if you try to use both. If so, you probably expect QUnit to do something that it won't be doing. So, we can throw a helpful error.

[rwjblue]

ember-qunit itself now supports beforeEach and afterEach (but setup and teardown still work also) as of https://github.com/rwjblue/ember-qunit/pull/125.

[rwjblue]

As of v0.2.3 we also pass through the first argument to the test callback (as documented in http://qunitjs.com/upgrade-guide-2.x/).

[rwjblue]

Updated ember-cli blueprints in ember-cli/ember-cli#3197.

[stefanpenner]

👍

[jayeff]

I took a stab at updating the ember-cli Documentation in ember-cli/ember-cli#3222

[Turbo87]

this seems no longer relevant, closing due to age