Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CI and dependencies. Dropped support for Node 12 and Ember 3.24 LTS. #388

Merged
merged 13 commits into from
Dec 17, 2022
Merged

Conversation

ijlee2
Copy link
Contributor

@ijlee2 ijlee2 commented Dec 16, 2022

Description

As a part of emberjs/ember.js#20162 and #387, I will create a few pull requests to update this repo, so that we can ease future maintenance.

I made the following changes in this pull request:

  • Commit 1: Dropped support for Node 12. When we are ready to cut a release, we will want to announce a major version.
  • Commits 2-4: Updated CI to be readable and make use of v3 actions (caching is simpler). Note that CI failed (error message: Cannot find module '@babel/core'), even though I didn't change any code.
  • Commits 5-10: Ran ember-cli-update to update ember-source from 3.28.8 to 4.9.3. Note that CI passed after updating the packages.
  • Commits 11-12: Replaced scenario-tester with ember-try (better documentation and support currently). Dropped Ember 3.20 and 3.24 from the test matrix. Added Ember 3.28 and 4.4 to the test matrix.
  • Commit 13: Updated the minimum supported versions in README.

References

@ijlee2 ijlee2 changed the title PR-01 Updated CI and dependencies. Dropped support for Node 12 and Ember 3.24 LTS. Dec 16, 2022
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
timeout-minutes: 5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good practice to set timeout-minutes to a low value so that CI can fail early when something goes wrong. (The default value is 360 minutes.)

Comment on lines +25 to +27
"link-test-app": "addon-dev link-test-app",
"lint": "concurrently \"npm:lint:*(!fix)\" --names \"lint:\"",
"lint:devdeps": "addon-dev sync-dev-deps --lint",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed like, the addon had been made a v2 addon before it was decided (e.g. via https://github.com/embroider-build/addon-blueprint) that workspaces are a good option.

At the moment, I'm thinking that it may be easier to introduce TypeScript before introducing yarn workspace.

"eslint-config-prettier": "^8.3.0",
"eslint-plugin-ember": "^10.5.4",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^11.2.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update eslint to v8 in a separate pull request.

@ijlee2 ijlee2 marked this pull request as ready for review December 16, 2022 15:52
@ijlee2 ijlee2 requested a review from a team December 16, 2022 15:52
@ijlee2 ijlee2 added breaking dependencies Pull requests that update a dependency file labels Dec 17, 2022
@ijlee2 ijlee2 merged commit e29e09d into ember-cli:master Dec 17, 2022
@ijlee2 ijlee2 deleted the pr-01 branch December 17, 2022 08:21
@bertdeblock
Copy link
Member

A bit late, but we can also added LTS 4.8 to the test scenario's?

@ijlee2
Copy link
Contributor Author

ijlee2 commented Dec 17, 2022

@bertdeblock Yep, I think adding 4.8 now is a good idea.

At the moment, I'm investigating why CI failed after merging the PR (seems to be an issue with dependencies). I'll get to both issues soon.

@ijlee2
Copy link
Contributor Author

ijlee2 commented Dec 17, 2022

The failed CI run seems to be related to a recent change in ember-qunit@v6.1.0.

https://github.com/emberjs/ember-qunit/pull/995/files#r1051368796

@ijlee2 ijlee2 added internal and removed dependencies Pull requests that update a dependency file labels Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants