-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CI and dependencies. Dropped support for Node 12 and Ember 3.24 LTS. #388
Conversation
runs-on: ubuntu-latest | ||
outputs: | ||
matrix: ${{ steps.set-matrix.outputs.matrix }} | ||
timeout-minutes: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good practice to set timeout-minutes
to a low value so that CI can fail early when something goes wrong. (The default value is 360
minutes.)
"link-test-app": "addon-dev link-test-app", | ||
"lint": "concurrently \"npm:lint:*(!fix)\" --names \"lint:\"", | ||
"lint:devdeps": "addon-dev sync-dev-deps --lint", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed like, the addon had been made a v2
addon before it was decided (e.g. via https://github.com/embroider-build/addon-blueprint) that workspaces are a good option.
At the moment, I'm thinking that it may be easier to introduce TypeScript before introducing yarn workspace.
"eslint-config-prettier": "^8.3.0", | ||
"eslint-plugin-ember": "^10.5.4", | ||
"eslint-config-prettier": "^8.5.0", | ||
"eslint-plugin-ember": "^11.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update eslint
to v8
in a separate pull request.
A bit late, but we can also added LTS 4.8 to the test scenario's? |
@bertdeblock Yep, I think adding 4.8 now is a good idea. At the moment, I'm investigating why CI failed after merging the PR (seems to be an issue with dependencies). I'll get to both issues soon. |
The failed CI run seems to be related to a recent change in https://github.com/emberjs/ember-qunit/pull/995/files#r1051368796 |
Description
As a part of emberjs/ember.js#20162 and #387, I will create a few pull requests to update this repo, so that we can ease future maintenance.
I made the following changes in this pull request:
v3
actions (caching is simpler). Note that CI failed (error message:Cannot find module '@babel/core'
), even though I didn't change any code.ember-cli-update
to updateember-source
from3.28.8
to4.9.3
. Note that CI passed after updating the packages.scenario-tester
withember-try
(better documentation and support currently). Dropped Ember 3.20 and 3.24 from the test matrix. Added Ember 3.28 and 4.4 to the test matrix.README
.References