Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced yarn workspaces #392

Merged
merged 7 commits into from
Dec 19, 2022
Merged

Introduced yarn workspaces #392

merged 7 commits into from
Dec 19, 2022

Conversation

ijlee2
Copy link
Contributor

@ijlee2 ijlee2 commented Dec 19, 2022

Description

During the investigation for #388, I realized that this project might have been converted to the v2 addon format before it was agreed (e.g. via embroider-build/addon-blueprint) that workspaces are a good option for v2 addons.

Using workspaces helps with maintenance in the following ways:

  • The dependencies of the source code are cleanly separated from those of the test app. (Before, the root package.json mixed the two sets of dependencies.)
  • We don't need to run yarn sync-dev-deps anymore. (sync-dev-deps doesn't remove unused dependencies from the root package.json. Before, maintainers risked forgetting to manually remove unused dependencies.)
  • The folder structure in this project aligns with that of many v2 addons. This will ease future onboarding.

Using workspaces does increase the project's complexity in these ways:

  • release-it needs a special plugin called @release-it-plugins/workspaces.
  • Documentations, such as README and CONTRIBUTING, need to be updated.

References

@ijlee2 ijlee2 marked this pull request as ready for review December 19, 2022 18:47
@ijlee2 ijlee2 merged commit b76366a into ember-cli:main Dec 19, 2022
@ijlee2 ijlee2 deleted the PR-05 branch December 19, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant