Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the investigation for #388, I realized that this project might have been converted to the v2 addon format before it was agreed (e.g. via
embroider-build/addon-blueprint
) that workspaces are a good option for v2 addons.Using workspaces helps with maintenance in the following ways:
package.json
mixed the two sets of dependencies.)yarn sync-dev-deps
anymore. (sync-dev-deps
doesn't remove unused dependencies from the rootpackage.json
. Before, maintainers risked forgetting to manually remove unused dependencies.)Using workspaces does increase the project's complexity in these ways:
release-it
needs a special plugin called@release-it-plugins/workspaces
.README
andCONTRIBUTING
, need to be updated.References
ember addon my-addon -b @embroider/addon-blueprint --yarn --skip-npm
)