no-test-import-export rule should allowed importing from tests/helpers folder

[raido]

I have hit use case where I have couple of helpers, like tests/helpers/setup-application-test.js which wrap default setupApplicationTest for additional setup.

Now with this rule all my helpers get triggered for lint error. For now I renamed the files but this seems inconvenient and also explicitly updating eslintrc.js to turn off this rule for just tests/helpers seems incorrect.

eslint-plugin-ember/lib/rules/no-test-import-export.js

Line 45 in 0183d45

if (importSource.endsWith('-test')) {

[rwjblue]

Ya, agree. Also emberjs/rfcs#637 will explicitly be having folks import from my-app/tests/helpers (using tests/helpers/index.js for some reexports) in all generated tests. The RFC is in FCP, and will likely land soon...

[raido]

Not sure this is fixed for relative path imports, see comment: #895 (review)

[bmish]

Follow-up fix: #911